deps: update V8 to 11.5 by targos · Pull Request #48456 · nodejs/node

targos · 2023-06-14T08:18:10Z

Based on #48029 with two additional commits.

deps: update V8 to 11.5.150.8
build: reset embedder string to "-node.0"
src: update NODE_MODULE_VERSION to 118
deps: always define V8_EXPORT_PRIVATE as no-op
deps: silence irrelevant V8 warning
deps: patch V8 to support compilation on win-arm64
deps: disable V8 concurrent sparkplug compilation
tools: update V8 gypfiles for 11.4
tools: add new V8 headers to distribution
lib: update usage of always on Atomics API
test: adapt debugger tests to V8 11.4
test: update flag to disable SharedArrayBuffer
tools: update V8 gypfiles for 11.5
test: adapt test-fs-write to V8 internal changes

nodejs-github-bot · 2023-06-14T08:18:18Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-06-14T08:21:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52250/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5395/

targos · 2023-06-14T08:21:14Z

@StefanStojanovic I've kept 63589e5. Can you point me to the V8 CL that would make it obsolete?

StefanStojanovic · 2023-06-14T10:10:56Z

@StefanStojanovic I've kept 63589e5. Can you point me to the V8 CL that would make it obsolete?

My third CL landed 5 days ago. That should be the last one needed. In case you need the other CLs, this is the second one that landed a month ago, and the first one that landed 2 months ago

targos · 2023-06-14T11:54:56Z

Thanks, I updated the PR to cherry-pick that last commit instead of the floating patch.

targos · 2023-06-14T11:56:12Z

Failure in shared lib build:

12:29:30 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512'
12:29:30 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/zlib/deps/zlib/cpu_features.o:(.bss+0x0): first defined here
12:29:30 collect2: error: ld returned 1 exit status
12:29:30 libnode.target.mk:546: recipe for target '/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode.so.118' failed
12:29:30 make[2]: *** [/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode.so.118] Error 1

Same on SmartOS:

12:27:09 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
12:27:09 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);
12:27:09 ld: fatal: file processing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/cctest

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

dllexport introduces issues when compiling with MSVC. PR-URL: nodejs#47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: nodejs#45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs#47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: [win][msvc] fix cross-compilation for arm64 Cross-compiling x64 to ARM64 on Windows fails with MSVC. The reason is the ProbeMemory function which uses asm() code prohibited in this case. This change adds conditionalizing on V8_TRAP_HANDLER_SUPPORTED thus removing the problematic parts of the code in MSVC cross-compilation. This extends https://chromium-review.googlesource.com/c/v8/v8/+/3964232 in a way, as it wraps ProbeMemory usage inside of the "#ifdef V8_TRAP_HANDLER_VIA_SIMULATOR" blocks. This follows https://chromium-review.googlesource.com/c/v8/v8/+/4403215 and https://chromium-review.googlesource.com/c/v8/v8/+/4489305 as a part of an effort to completely fix cross-compilation with MSVC. Change-Id: I59d9a995fbc8ee1cee2807429fd44d8043c178fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4574697 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/main@{#88147} Refs: v8/v8@15e31d6

Accept a new `step` break message.

`--no-harmony-sharedarraybuffer` was removed from V8 but it's still possible to disable the feature with `--enable-sharedarraybuffer-per-context`.

targos · 2023-06-21T10:23:04Z

I don't see what's special about x86_cpu_enable_avx512. It's defined the same way as, for example, x86_cpu_enable_simd, which isn't causing any issues.

/cc @nodejs/cpp-reviewers

wa-Nadoo · 2023-06-21T22:16:03Z

5258be6 can be dropped due to upstream bug has been fixed.

targos · 2023-06-26T09:49:51Z

5258be6 can be dropped due to upstream bug has been fixed.

Upstream bug was closed, but a fix needs to happen on the Node.js side.

See #47297 and #47452

targos · 2023-07-09T10:29:49Z

#48710

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 14, 2023

targos mentioned this pull request Jun 14, 2023

deps: update V8 to 11.4 #48029

Closed

nodejs deleted a comment from nodejs-github-bot Jun 14, 2023

targos force-pushed the v8-115 branch from 6209a78 to 414617a Compare June 14, 2023 11:54

targos mentioned this pull request Jun 14, 2023

deps: delete deps/v8/third_party/zlib #47493

Closed

This was referenced Jun 15, 2023

CI Reliability 2023-06-15 nodejs/reliability#594

Open

CI Reliability 2023-06-21 nodejs/reliability#595

Open

targos and others added 13 commits June 21, 2023 12:14

deps: update V8 to 11.5.150.10

0ddf2b3

build: reset embedder string to "-node.0"

e8726f8

src: update NODE_MODULE_VERSION to 118

5801de2

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

tools: update V8 gypfiles for 11.4

273686f

tools: add new V8 headers to distribution

fd29941

lib: update usage of always on Atomics API

baa57f1

test: adapt debugger tests to V8 11.4

cc27e4e

Accept a new `step` break message.

test: update flag to disable SharedArrayBuffer

ada4cc2

`--no-harmony-sharedarraybuffer` was removed from V8 but it's still possible to disable the feature with `--enable-sharedarraybuffer-per-context`.

tools: update V8 gypfiles for 11.5

83435a2

test: adapt test-fs-write to V8 internal changes

a999c68

targos force-pushed the v8-115 branch from 414617a to a999c68 Compare June 21, 2023 10:16

targos closed this Jul 9, 2023

targos deleted the v8-115 branch September 13, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: update V8 to 11.5#48456

deps: update V8 to 11.5#48456
targos wants to merge 14 commits intonodejs:mainfrom
targos:v8-115

targos commented Jun 14, 2023

Uh oh!

nodejs-github-bot commented Jun 14, 2023

Uh oh!

nodejs-github-bot commented Jun 14, 2023 •

edited by targos

Loading

Uh oh!

targos commented Jun 14, 2023

Uh oh!

StefanStojanovic commented Jun 14, 2023

Uh oh!

targos commented Jun 14, 2023

Uh oh!

targos commented Jun 14, 2023 •

edited

Loading

Uh oh!

targos commented Jun 21, 2023

Uh oh!

wa-Nadoo commented Jun 21, 2023

Uh oh!

targos commented Jun 26, 2023

Uh oh!

targos commented Jul 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

targos commented Jun 14, 2023

Uh oh!

nodejs-github-bot commented Jun 14, 2023

Uh oh!

nodejs-github-bot commented Jun 14, 2023 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 14, 2023

Uh oh!

StefanStojanovic commented Jun 14, 2023

Uh oh!

targos commented Jun 14, 2023

Uh oh!

targos commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 21, 2023

Uh oh!

wa-Nadoo commented Jun 21, 2023

Uh oh!

targos commented Jun 26, 2023

Uh oh!

targos commented Jul 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Jun 14, 2023 •

edited by targos

Loading

targos commented Jun 14, 2023 •

edited

Loading