test: revert parallel wpt commits #47627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
the
commit-queue-rebase
nodejs-github-bot
added
build
panva
added
dont-land-on-v14.x
dont-land-on-v18.x
|
fast-track
|
|
Fast-track has been requested by @panva. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Apr 19, 2023
anonrig
approved these changes
Apr 20, 2023
KhafraDev
approved these changes
Apr 20, 2023
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47627 ✔ Done loading data for nodejs/node/pull/47627 ----------------------------------- PR info ------------------------------------ Title test: revert parallel wpt commits (#47627) Author Filip Skokan (@panva) Branch panva:wpt-reverts -> nodejs:main Labels build, tools, fast-track, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, commit-queue-rebase, dont-land-on-v18.x Commits 2 - Revert "tools: ensure failed daily wpt run still generates a report" - Revert "test: run WPT files in parallel again" Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/47627 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47627 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Revert "tools: ensure failed daily wpt run still generates a report" ⚠ - Revert "test: run WPT files in parallel again" ℹ This PR was created on Wed, 19 Apr 2023 20:57:57 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393002791 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393073980 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393228084 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-20T06:35:12Z: https://ci.nodejs.org/job/node-test-pull-request/51375/ - Querying data for job/node-test-pull-request/51375/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4752023065 |
|
Landed in 12094bc...607715e |
|
See #47635 for the fix. |
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #47283 and #47376 because the changes in the former allow multi-variant test file workers to be terminated before finishing, not reporting the results at all, see e.g. here in 19.x, 20.x, and nightly columns, those are the ones where #47283 has landed.
I will refactor the WPT Runner instead of constantly fixing the untestable.