test: run WPT files in parallel again#47283
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 31, 2023
Merged
Conversation
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
targos
reviewed
Mar 28, 2023
Comment on lines
+418
to
+413
| if (queue.length > 0) { | ||
| execute(queue.shift()); | ||
| } |
Member
There was a problem hiding this comment.
This is not returned or awaited. Is there a risk of unhandled rejection?
Member
Author
There was a problem hiding this comment.
It behaves as expected even with the WPT suite updated (like the daily WPT job does).
This is the await in the queue.
await events.once(worker, 'exit').catch(() => {});That being said, I am aware it's just a basic concurrency limit function implementation...
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
18 tasks
This comment was marked as resolved.
This comment was marked as resolved.
panva
force-pushed
the
try-wpt-files-parallel
branch
from
77fed52 to
313c51e
Compare
panva
added
request-ci
Member
Author
|
Before: After: Ran on an M1 Macbook Pro https://ci.nodejs.org/job/node-stress-single-test/391/console |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
34 tasks
targos
approved these changes
Mar 31, 2023
panva
added
the
author ready
anonrig
approved these changes
Mar 31, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c05689e |
This was referenced Apr 1, 2023
panva
added
dont-land-on-v14.x
dont-land-on-v20.x
Member
Author
|
not landing yet because tonight's daily WPT did not generate a report for current-nightly where this was included, will investigate. |
panva
removed
dont-land-on-v14.x
dont-land-on-v20.x
Merged
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows WPT suites as well as individual WPT files in them to run in parallel.
Refs: #47146
Refs: #47273 (review)