-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v19.x] deps: V8: cherry-pick f09dde9fbb54 #47239
Conversation
Review requested:
|
@richardlau I've noticed Windows CI failed for this PR. This happened because this commit is missing from your branch. Please cherry-pick it and rerun the CI. The commit from my other PR fixes the test at hand, so once it lands, those changes will be sufficient on their own. Additionally, by going through 2 builds started on this PR, I've seen that |
32385b4
to
f5c68a3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase is wrong (currently 50 commits in this PR)
This PR was correct until v19.x-staging was rebased 😞. I won't be able to fix this up until tonight or tomorrow. |
There's no need to fix up. Last CI was green so we can land it |
Original commit message: Revert "[resultdb] Add ResultDB indicator" This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005. Reason for revert: breaks flake bisect: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview The change added the implicit requirement to run testing with vpython3, which is not given everywhere. Original change's description: > [resultdb] Add ResultDB indicator > > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later). > > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator. > > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 . > > > V8-Recipe-Flags: resultdb > Bug: v8:13316 > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385 > Commit-Queue: Liviu Rau <liviurau@google.com> > Reviewed-by: Alexander Schulze <alexschulze@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83672} Bug: v8:13316 Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83677} Refs: v8/v8@f09dde9
74f6b63
to
48fc442
Compare
Original commit message: Revert "[resultdb] Add ResultDB indicator" This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005. Reason for revert: breaks flake bisect: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview The change added the implicit requirement to run testing with vpython3, which is not given everywhere. Original change's description: > [resultdb] Add ResultDB indicator > > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later). > > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator. > > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 . > > > V8-Recipe-Flags: resultdb > Bug: v8:13316 > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385 > Commit-Queue: Liviu Rau <liviurau@google.com> > Reviewed-by: Alexander Schulze <alexschulze@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83672} Bug: v8:13316 Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83677} Refs: v8/v8@f09dde9 PR-URL: #47239 Fixes: nodejs/build#3221 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Landed in a978ca6. @gengjiawen FWIW
commit-queue
|
Original commit message:
Refs: v8/v8@f09dde9
Fixes: nodejs/build#3221
cc @nodejs/v8-update