V8 CI broken on v19.x #3221
Labels
Comments
@miladfarca came across this with the upstream V8 work. From nodeshift/v8-build@60937fc it looks like this was introduced in https://crrev.com/c/3905385 but that looks like it was reverted in https://chromium-review.googlesource.com/c/v8/v8/+/3952131 (which is probably why the main branch isn't affected). |
|
V8 backport PR: nodejs/node#47239 |
richardlau
added a commit
to nodejs/node
that referenced
this issue
Apr 13, 2023
Original commit message:
Revert "[resultdb] Add ResultDB indicator"
This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.
Reason for revert: breaks flake bisect:
https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview
The change added the implicit requirement to run testing with
vpython3, which is not given everywhere.
Original change's description:
> [resultdb] Add ResultDB indicator
>
> Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
>
> If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
>
> To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
>
>
> V8-Recipe-Flags: resultdb
> Bug: v8:13316
> Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
> Commit-Queue: Liviu Rau <liviurau@google.com>
> Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83672}
Bug: v8:13316
Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#83677}
Refs: v8/v8@f09dde9
PR-URL: #47239
Fixes: nodejs/build#3221
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example: https://ci.nodejs.org/job/node-test-commit-v8-linux/5221/
Main branch doesn't seem affected (it's on a more recent version of V8): https://ci.nodejs.org/job/node-test-commit-v8-linux/5222/
The text was updated successfully, but these errors were encountered: