Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: expose reporter for use in run api #47238
test_runner: expose reporter for use in run api #47238
Changes from all commits
3db2b52
0e16ae4
7d1ba82
16edd36
6f8b4ae
58a5989
b123070
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that cjs-module-lexer will be able to pick up this pattern as named exports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a pretty common pattern in node's built-in modules, so it probably does:
node/lib/crypto.js
Line 340 in 9dbb162
node/lib/buffer.js
Line 1392 in 9dbb162
node/lib/dns.js
Line 345 in 9dbb162
node/lib/os.js
Line 399 in 9dbb162
node/lib/zlib.js
Line 926 in 9dbb162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably doesn’t but we don’t use
cjs-module-lexer
for core modules, because core modules are not CJS (or at least, not regular CJS) and the use of named imports for core modules predates the introduction ofcjs-module-lexer
.