Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: expose reporter for use in run api #47238

Merged
merged 7 commits into from
Mar 28, 2023
Merged

test_runner: expose reporter for use in run api #47238

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3db2b52
test_runner: expose reporter for use in run api
atlowChemi Mar 23, 2023
0e16ae4
test_runner: CR - fix lint error & cleaner UT
atlowChemi Mar 24, 2023
7d1ba82
test_runner: fix lint error
atlowChemi Mar 24, 2023
16edd36
test_runner: CR add UT & lazy require
atlowChemi Mar 25, 2023
6f8b4ae
test_runner: CR cleanup
atlowChemi Mar 25, 2023
58a5989
fix test
atlowChemi Mar 26, 2023
b123070
cr proto:null
atlowChemi Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cr proto:null
  • Loading branch information
@atlowChemi
atlowChemi committed Mar 26, 2023
commit b123070defc703ff3ac810f7e48b106eb4580a9c
1 change: 1 addition & 0 deletions lib/test/reporters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ let spec;
let tap;

ObjectDefineProperties(module.exports, {
atlowChemi marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure that cjs-module-lexer will be able to pick up this pattern as named exports?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a pretty common pattern in node's built-in modules, so it probably does:

node/lib/crypto.js

Line 340 in 9dbb162

ObjectDefineProperties(module.exports, {

node/lib/buffer.js

Line 1392 in 9dbb162

ObjectDefineProperties(module.exports, {

node/lib/dns.js

Line 345 in 9dbb162

ObjectDefineProperties(module.exports, {

node/lib/os.js

Line 399 in 9dbb162

ObjectDefineProperties(module.exports, {

node/lib/zlib.js

Line 926 in 9dbb162

ObjectDefineProperties(module.exports, {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn’t but we don’t use cjs-module-lexer for core modules, because core modules are not CJS (or at least, not regular CJS) and the use of named imports for core modules predates the introduction of cjs-module-lexer.

__proto__: null,
dot: {
__proto__: null,
configurable: true,
Expand Down