Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-http-max-sockets as flaky on win32 #47134

Merged
merged 1 commit into from
Mar 17, 2023
Merged

test: mark test-http-max-sockets as flaky on win32 #47134

merged 1 commit into from
Mar 17, 2023
+2 −0

Conversation

tniessen
Copy link
Member

Current Windows CI build trend:

build trend of node-test-binary-windows-js-suites showing almost only failures recently

I am not sure if marking it as flaky is going to be enough. Maybe we have to skip it entirely, but that's something that we should try to avoid.

Refs: #47116

@tniessen tniessen added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 17, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
@tniessen tniessen mentioned this pull request Mar 17, 2023
Closed
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50420/

@tniessen
Copy link
Member Author

Test was correctly detected as being flaky in the previous Jenkins run, but some other tests on other platforms flaked, too...

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9e9f68a into nodejs:main Mar 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9e9f68a

@tniessen tniessen mentioned this pull request Mar 17, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 18, 2023
Open
23 tasks
targos pushed a commit that referenced this pull request Mar 18, 2023
@tniessen @targos
test: mark test-http-max-sockets as flaky on win32
7bcfd18 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This was referenced Mar 19, 2023
Open
Open
Open
@debadree25 debadree25 mentioned this pull request Mar 21, 2023
Closed
This was referenced Apr 3, 2023
Merged
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
test: mark test-http-max-sockets as flaky on win32
713b412 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @anonrig @BethGriggs