Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #47131

Merged
merged 1 commit into from
Mar 19, 2023
Merged

test,crypto: update WebCryptoAPI WPT #47131

merged 1 commit into from
Mar 19, 2023

Conversation

panva
Copy link
Member

@panva panva commented Mar 17, 2023

Just git node wpt WebCryptoAPI

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Mar 17, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen
Copy link
Member

@panva looks like all CI failures are due to #47116, which should not be as much of an issue now that #47134 was merged. I'm not sure if resuming CI actually rebases on top of main every time -- so feel free to either resume or start a new CI :)

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
tniessen
tniessen approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50422/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
This was referenced Mar 18, 2023
Open
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 142d6af into nodejs:main Mar 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 142d6af

@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Open
17 tasks
@panva panva deleted the wpt-update-crypto branch March 20, 2023 10:53
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Open
19 tasks
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
445e942 
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
65955f1 
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
873606b 
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @tniessen @lpinca