test: remove useless require('../common') from WPTs#46796
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 25, 2023
Merged
test: remove useless require('../common') from WPTs#46796nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Feb 23, 2023
legendecas
approved these changes
Feb 23, 2023
panva
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
lpinca
approved these changes
Feb 23, 2023
panva
added
the
commit-queue
25 tasks
jasnell
approved these changes
Feb 24, 2023
targos
approved these changes
Feb 24, 2023
28 tasks
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 11e37e0 |
15 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Contributor
|
@panva this broke tests in v18.x-staging. do you mind opening a backport PR? |
panva
added a commit
to panva/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: https://github.com/nodejs/node/pull/?????
panva
added a commit
to panva/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
Member
Author
Didn't break anything, just didn't land clean. #47506 |
Member
|
FWIW, the reason for the inclusion was because that adds a check on exit for leaking things into the global space. |
Member
Author
Which some of the WPTs explicitly do to be able to run 🤷♂️. But they do so in their own spawned workers the WPTs execute in. |
panva
added a commit
to panva/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
panva
added a commit
to panva/node
that referenced
this pull request
Apr 12, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need to put a useless
require('../common');at the top of every WPT startup file.