[v18.x backport] test: remove useless require('../common') from WPTs#47506
Closed
panva wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] test: remove useless require('../common') from WPTs#47506panva wants to merge 1 commit intonodejs:v18.x-stagingfrom
panva wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
nodejs-github-bot
added
needs-ci
panva
added a commit
to panva/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
panva
force-pushed
the
requested-backports-v18.x
branch
from
c493699 to
1e37b3e
Compare
panva
added a commit
to panva/node
that referenced
this pull request
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
panva
force-pushed
the
requested-backports-v18.x
branch
from
1e37b3e to
b4e645d
Compare
lpinca
approved these changes
Apr 11, 2023
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
panva
force-pushed
the
requested-backports-v18.x
branch
from
b4e645d to
2699cd2
Compare
panva
added
the
author ready
Collaborator
Contributor
|
@panva I don't know if this will make the release since the tests are still running, but I can land this after the release goes out so that it's ready for the next one. |
Collaborator
danielleadams
approved these changes
May 17, 2023
Contributor
|
Landed in 843ecd2 |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
PR-URL: nodejs#46796 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Backport-PR-URL: nodejs#47506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #46796