build: add --v8-disable-object-print flag#45458
build: add --v8-disable-object-print flag#45458nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
build
| 'support, thus much slower execution)') | ||
|
|
||
| parser.add_argument('--v8-enable-object-print', | ||
| parser.add_argument('--v8-disable-object-print', |
There was a problem hiding this comment.
We could keep --v8-enable-object-print as a valid option in addition to adding --v8-disable-object-print in case anyone is using it, otherwise they'll break
There was a problem hiding this comment.
Thanks for your suggestion, I keep the -v8-enable-object-print flag and add the --v8-disable-object-print flag.
If I specify both flags at the same time, We get an exception with a message like Only one of the --v8-enable-object-print or --v8-disable-object-print options an be specified at a time..
There was a problem hiding this comment.
I believe this introduced a bug? I cannot use "disable" flag because "enable" flag is default True, so if I "disable" then they're both True...
Downloading the source tarball on Nodejs' website for LTS 18.13.0 yields:
python3 ./configure --prefix=/opt/base --shared-zlib --v8-disable-object-print --without-corepack --without-dtrace --without-etw --without-inspector --without-intl --without-node-code-cache --without-node-snapshot --without-npm --without-ssl
Node.js configure: Found Python 3.9.10...
Traceback (most recent call last):
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/./configure", line 28, in <module>
import configure
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/configure.py", line 2062, in <module>
configure_v8(output)
File "/Users/Hames/Repos/core/contrib/node-v18.13.0/configure.py", line 1547, in configure_v8
raise Exception(
Exception: Only one of the --v8-enable-object-print or --v8-disable-object-print options can be specified at a time.
Even though the enable flag is never specified.
This is because the options object has the argparse defaults resolved, which means the enable flag is True if not specified... :/
parser.add_argument('--v8-enable-object-print',
action='store_true',
dest='v8_enable_object_print',
default=True, # HERE
help='compile V8 with auxiliary functions for native debuggers')
parser.add_argument('--v8-disable-object-print',
action='store_true',
dest='v8_disable_object_print',
default=False,
help='disable the V8 auxiliary functions for native debuggers')
configure.py
Outdated
| help='compile V8 with auxiliar functions for native debuggers') | ||
| dest='v8_disable_object_print', | ||
| default=False, | ||
| help='disable the V8 auxiliar functions for native debuggers') |
There was a problem hiding this comment.
Since we're editing this line, might as well fix this typo:
| help='disable the V8 auxiliar functions for native debuggers') | |
| help='disable the V8 auxiliary functions for native debuggers') |
There was a problem hiding this comment.
Thanks, I will fix typo.
--v8-enable-object-print flag is set by default true. so, no way of disable this flag. add a --v8-disable-object-print flag instead that defaults to false. Fixes: nodejs#45433
fossamagna
force-pushed
the
add-v8-disable-object-print-flag
branch
from
c041989 to
f50e2b4
Compare
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6638f09 |
5 participants
--v8-enable-object-printflag is set by default true. so, no way of disable this flag.remove
--v8-enable-object-printflag.add a
--v8-disable-object-printflag instead that defaults to false.Fixes: #45433