Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: no way to disable V8 "object print" during ./configure #45433

Closed
mscdex opened this issue Nov 11, 2022 · 0 comments · Fixed by #45458
Closed

build: no way to disable V8 "object print" during ./configure #45433

mscdex opened this issue Nov 11, 2022 · 0 comments · Fixed by #45458
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 11, 2022

Version

all

Platform

n/a

Subsystem

build

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

​

Additional information

Currently there is only --v8-enable-object-print, which defaults to true, making it (seemingly?) impossible to disable the "object print" feature. I feel like if this flag is defaulting to true/enabled, this should really be a --v8-disable-object-print flag instead that defaults to false.
@mscdex mscdex added good first issue Issues that are suitable for first-time contributors. build Issues and PRs related to build files or the CI. labels Nov 11, 2022
fossamagna added a commit to fossamagna/node that referenced this issue Nov 14, 2022
@fossamagna
build: add --v8-disable-object-print flag
c041989 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag. remove --v8-enable-object-print flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: nodejs#45433
@fossamagna fossamagna mentioned this issue Nov 14, 2022
Merged
fossamagna added a commit to fossamagna/node that referenced this issue Nov 15, 2022
@fossamagna
build: add --v8-disable-object-print flag
f50e2b4 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: nodejs#45433
nodejs-github-bot pushed a commit that referenced this issue Nov 17, 2022
@fossamagna
build: add --v8-disable-object-print flag
6638f09 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this issue Nov 21, 2022
@fossamagna @ruyadorno
build: add --v8-disable-object-print flag
62ef1eb 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@fossamagna @danielleadams
build: add --v8-disable-object-print flag
e77cb26 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@fossamagna @danielleadams
build: add --v8-disable-object-print flag
a6190e8 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@fossamagna @danielleadams
build: add --v8-disable-object-print flag
89d1eb5 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this issue Jan 4, 2023
@fossamagna @danielleadams
build: add --v8-disable-object-print flag
1331485 
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
PR-URL: #45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add --v8-disable-object-print flag fossamagna/node
1 participant
@mscdex