Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: update webcrypto WPT #43421

Closed
wants to merge 6 commits into from
Closed

crypto: update webcrypto WPT #43421

wants to merge 6 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Jun 14, 2022 •
edited
Loading

  • updates the WebCryptoAPI WPT and status file
  • with a simple location global allows to stop skipping lots of tests

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Jun 14, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 14, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@panva panva requested review from jasnell and tniessen June 14, 2022 09:36
@panva
Copy link
Member Author

panva commented Jun 14, 2022

cc @nodejs/crypto

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 14, 2022
@panva panva changed the title crypto: update webcrypto WPT crypto: update webcrypto WPT and fix deriveBits Jun 14, 2022
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. experimental Issues and PRs related to experimental features. labels Jun 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva mentioned this pull request Jun 14, 2022
Closed
@panva panva changed the title crypto: update webcrypto WPT and fix deriveBits crypto: updates to webcrypto WPT and various fixes Jun 14, 2022
@panva panva marked this pull request as draft June 14, 2022 13:39
@panva panva marked this pull request as ready for review June 14, 2022 13:55
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
Copy link
Member Author

panva commented Jun 14, 2022 •
edited
Loading

@jasnell @tniessen when it comes to the rest of the WPT failures

  • vast majority of them is because we don't reject with the correct error classes

    • (assert_equals) upon input validation, due to use of existing validators
    • (assert_equals) upon operation failure, due to return of a promise that gets rejected with openssl failures that we don't catch and rethrow as OperationError

  • (assert_unreached) the rest is due to SecretKeyObject not supporting zero-length secrets.

I would appreciate your thoughts on these individual WPT failure types

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@jasnell
Copy link
Member

jasnell commented Jun 14, 2022

I would appreciate your thoughts on these individual WPT failure types

I'd say let's just go ahead and match spec behavior.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44553/

@panva
Copy link
Member Author

panva commented Jun 14, 2022 •
edited
Loading

We'll need to increase the WPT tests timeout

Any ideas where to do so?

@panva panva marked this pull request as draft June 14, 2022 19:18
@panva panva mentioned this pull request Jun 14, 2022
Closed
@panva
Copy link
Member Author

panva commented Jun 14, 2022

I'll come back to updating WPTs later, the individual fixes with their tests are in #43431

@panva panva added the wip Issues and PRs that are still a work in progress. label Jun 14, 2022
@panva panva changed the title crypto: updates to webcrypto WPT and various fixes crypto: update webcrypto WPT Jun 14, 2022
@panva panva removed the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 14, 2022
This was referenced Jun 15, 2022
Open
Open
@panva panva closed this Jun 16, 2022
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Open
31 tasks
@panva panva deleted the webcrypto-bump-wpt branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panva @nodejs-github-bot @jasnell