Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix webcrypto WPT expected failures #43423

Closed
wants to merge 1 commit into from
Closed

crypto: fix webcrypto WPT expected failures #43423

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Jun 14, 2022 •
edited
Loading

Since we skip a big chunk of WPTs these expected failures were not exhibited.

  • digest() invalid algorithm which happens to collide with other normalizeHashName names
  • empty usages in generateKey()
  • invalid RSA algorithm publicExponent values in generateKey()

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Jun 14, 2022
@panva panva requested review from jasnell and tniessen June 14, 2022 12:21
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44536/

@panva
Copy link
Member Author

panva commented Jun 14, 2022

Included in #43421 so that i don't have to space out these related PRs.

@panva panva closed this Jun 14, 2022
@panva panva deleted the fix-webcrypto-expecting-failures branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell Awaiting requested review from jasnell

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panva @nodejs-github-bot