tools: fix installing headers on windows #40943
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@nodejs/python @nodejs/platform-windows |
cclauss
reviewed
Nov 25, 2021
|
The joys of https://docs.python.org/3/library/os.html#os.sep I would be happier to see this file reworked to use the more intuitive and less error-prone |
Installing headers on windows skips v8 headers in folders cppgc and libplatform caused by difference in directory separators returned by os.walk vs v8_headers whitelist. This change simply normalizes separators to match v8_headers whitelist.
Kukkimonsuta
force-pushed
the
fix-install-headers-on-windows
branch
from
9a294c6 to
9973ebc
Compare
|
Fixed the code style based on suggested change. I briefly looked into changing the file to pathlib, but I don't think it's something I'm able to do right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing headers on windows (
python3 .\tools\install.py install) skips v8 headers in folderscppgcandlibplatformcaused by difference in directory separators returned byos.walkvsv8_headerswhitelist. This change simply normalizes separators to matchv8_headerswhitelist.