Skip to content

Conversation

@juanarbol
Copy link
Member

Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. v14.x labels Apr 13, 2021
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 13, 2021
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
@juanarbol juanarbol force-pushed the backport-38109-to-v14.x branch from 1cc8010 to 76f6c50 Compare April 13, 2021 19:38
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 13, 2021
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
@juanarbol juanarbol force-pushed the backport-38109-to-v14.x branch from 76f6c50 to 48db6a4 Compare April 13, 2021 23:43
aduh95
aduh95 previously approved these changes Apr 13, 2021
@aduh95 aduh95 dismissed their stale review April 20, 2021 13:31

Correct value is 2**32-1 on v14.x

Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
@juanarbol juanarbol force-pushed the backport-38109-to-v14.x branch from 48db6a4 to c25d394 Compare April 20, 2021 16:39
targos pushed a commit that referenced this pull request Apr 24, 2021
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #38232
@targos
Copy link
Member

targos commented Apr 24, 2021

Landed in 9930b6b

@targos targos closed this Apr 24, 2021
@juanarbol juanarbol deleted the backport-38109-to-v14.x branch August 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants