Skip to content

doc: update buffer.constants.MAX_LENGTH #38109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

doc: update buffer.constants.MAX_LENGTH #38109

wants to merge 4 commits into from

Conversation

@Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented Apr 6, 2021

This PR

  1. updates buffer.constants.MAX_LENGTH for different Node.js versions in 64-bit platform;
  2. adds a link to v8::TypedArray::kMaxLength as an informative note.

Fixes: #38093

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2021
RaisinTen
RaisinTen reviewed Apr 6, 2021
View reviewed changes
aduh95
aduh95 reviewed Apr 6, 2021
View reviewed changes
@Ayase-252
Copy link
Member Author

Ayase-252 commented Apr 7, 2021 •
edited
Loading

@aduh95 I have documented changes in YAML headers. But I did not find a good way to incorprate the "initial" value 2 ** 31 - 1 into changes field, since it is not a change technically. Should I mention it in the main paragraph as the newest commit? Thanks.

aduh95
aduh95 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without my suggestions.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
@targos
Copy link
Member

targos commented Apr 11, 2021

@aduh95 added backport-requested-v14.x

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?

@aduh95
Copy link
Contributor

aduh95 commented Apr 11, 2021

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?

@targos the value is different in v15.x and v14.x, I believe a manual backport is necessary to adjust the value on the v14.x branch. Maybe a dont-land label is more appropriate? In any case, this should not be backported as is.

jasnell pushed a commit that referenced this pull request Apr 12, 2021
@Ayase-252 @jasnell
doc: update buffer.constants.MAX_LENGTH
756d2e4 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 12, 2021

Landed in 756d2e4

@jasnell jasnell closed this Apr 12, 2021
@Ayase-252 Ayase-252 deleted the fix/38093 branch April 13, 2021 14:26
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 13, 2021
@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
1cc8010 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Apr 13, 2021
Closed
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 13, 2021
@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
76f6c50 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 13, 2021
@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
48db6a4 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Ayase-252 @BethGriggs
doc: update buffer.constants.MAX_LENGTH
fa2b2b7 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 20, 2021
@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
c25d394 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#38232
targos pushed a commit that referenced this pull request Apr 24, 2021
@Ayase-252 @targos
doc: update buffer.constants.MAX_LENGTH
9930b6b 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #38232
@targos targos added backported-to-v14.x and removed backport-requested-v14.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

buffer: buffer.constants.MAX_LENGTH is larger than expected

6 participants

@Ayase-252 @targos @aduh95 @jasnell @RaisinTen @nodejs-github-bot