Skip to content

Conversation

@MylesBorins
Copy link
Contributor

No description provided.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 9, 2015

LGTM

@evanlucas
Copy link
Contributor

LGTM. yay

@Trott
Copy link
Member

Trott commented Nov 9, 2015

:shipit:

@Trott
Copy link
Member

Trott commented Nov 9, 2015

Er, uh, actually, aren't the collaborators listed in alphabetical order by GitHub username?

@evanlucas
Copy link
Contributor

good point

@MylesBorins
Copy link
Contributor Author

fixed

@MylesBorins
Copy link
Contributor Author

Can I get another round of LGTM 😄

@evanlucas
Copy link
Contributor

LGTM

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015
@Trott
Copy link
Member

Trott commented Nov 9, 2015

LGTM

1 similar comment
@saghul
Copy link
Member

saghul commented Nov 9, 2015

LGTM

@MylesBorins
Copy link
Contributor Author

Landed in 7b89a3d

MylesBorins pushed a commit that referenced this pull request Nov 9, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins MylesBorins closed this Nov 9, 2015
MylesBorins pushed a commit that referenced this pull request Nov 10, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
MylesBorins pushed a commit that referenced this pull request Nov 17, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in v4.x-staging in 64e6d06

MylesBorins pushed a commit that referenced this pull request Dec 4, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 17, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 23, 2015
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants