v4.2.2+1 commit candidates

[rvagg]

Thanks to @thealphanerd for a champion effort in merging a bunch of commits in to v4.x-staging we now have a pretty good list to look at and discuss whether there's anything we might consider inappropriate for the next LTS release. I believe that all of these commits fall after v5.0.0 so have not been included in a stable release yet so they still have that hurdle to go through. The important part is the discussion so we can further refine our criteria for what should make it in to LTS and what shouldn't. So if anything in this list stands out as a potential concern then please raise it for discussion. @thealphanerd perhaps you can fill us in on any borderline commits that didn't make it but may be worth discussing?

branch-diff v4.x v4.x-staging --group

• [935b8be8f6] - Add missing va_end before return (Ömer Fadıl Usta) #3565
• [aef3d549af] - build: fix configuring with prebuilt libraries (Markus Tzoe) #3135
• [e86817cf81] - cluster: send suicide message on disconnect (cjihrig) #3720
• [c37a560df4] - crypto: Improve error checking and reporting (Stefan Budeanu) #3753
• [44d4a02694] - deps: upgrade npm to 2.14.9 (Forrest L Norvell) #3686
• [a632db5ba6] - dns: prevent undefined values in results (Junliang Yan) #3696
• [877d86d32d] - doc: add link to [customizing util.inspect colors]. (Jesse McCarthy) #3749
• [65267bcdec] - doc: sort tls alphabetically (Tristian Flanagan) #3662
• [46356965ff] - doc: sort stream alphabetically (Tristian Flanagan) #3662
• [600bc56561] - doc: sort net alphabetically (Tristian Flanagan) #3662
• [256467208e] - doc: sort process alphabetically (Tristian Flanagan) #3662
• [e6704393f6] - doc: sort zlib alphabetically (Tristian Flanagan) #3662
• [57f298f482] - doc: sort util alphabetically (Tristian Flanagan) #3662
• [cb62bb2a1b] - doc: sort https alphabetically (Tristian Flanagan) #3662
• [2cac10d9c0] - doc: sort http alphabetically (Tristian Flanagan) #3662
• [133f84e352] - doc: sort modules alphabetically (Tristian Flanagan) #3662
• [fdeaec50d3] - doc: sort readline alphabetically (Tristian Flanagan) #3662
• [45f7d75c61] - doc: sort repl alphabetically (Tristian Flanagan) #3662
• [babc561cbf] - doc: sort string_decoder alphabetically (Tristian Flanagan) #3662
• [cf96a53520] - doc: sort timers alphabetically (Tristian Flanagan) #3662
• [ea66bd3a54] - doc: sort tty alphabetically (Tristian Flanagan) #3662
• [fd2e926313] - doc: sort url alphabetically (Tristian Flanagan) #3662
• [0814b8c0c9] - doc: sort vm alphabetically (Tristian Flanagan) #3662
• [d7b685c63f] - doc: sort querystring alphabetically (Tristian Flanagan) #3662
• [84b9376b45] - doc: sort punycode alphabetically (Tristian Flanagan) #3662
• [78277495df] - doc: sort path alphabetically (Tristian Flanagan) #3662
• [bbd00ee296] - doc: sort os alphabetically (Tristian Flanagan) #3662
• [806b6944fc] - doc: sort globals alphabetically (Tristian Flanagan) #3662
• [fc346fb209] - doc: sort fs alphabetically (Tristian Flanagan) #3662
• [1f644b1b5a] - doc: sort events alphabetically (Tristian Flanagan) #3662
• [c8ba5570d9] - doc: sort errors alphabetically (Tristian Flanagan) #3662
• [128d100a0a] - doc: sort dgram alphabetically (Tristian Flanagan) #3662
• [ecfbbf0fb9] - doc: sort crypto alphabetically (Tristian Flanagan) #3662
• [720f068637] - doc: sort dns alphabetically (Tristian Flanagan) #3662
• [1b668b5ce3] - doc: sort console alphabetically (Tristian Flanagan) #3662
• [448523636a] - doc: sort cluster alphabetically (Tristian Flanagan) #3662
• [2c5e7ede79] - doc: sort child_process alphabetically (Tristian Flanagan) #3662
• [2433e3de96] - doc: sort buffer alphabetically (Tristian Flanagan) #3662
• [2f8caaf756] - doc: sort assert alphabetically (Tristian Flanagan) #3662
• [8b6120d84f] - doc: add note on tls connection meta data methods (Tyler Henkel) #3746
• [3435f87613] - doc: add note to util.isBuffer (Evan Lucas) #3790
• [a49dd8913c] - doc: add romankl to collaborators (Roman Klauke) #3725
• [5cbfb76919] - doc: add saghul as a collaborator (Saúl Ibarra Corretgé)
• [64e6d06ad7] - doc: add thealphanerd to collaborators (Myles Borins) #3723
• [9970b76623] - doc: update lts description in the collaborator guide (James M Snell) #3668
• [9ce1f75cb7] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #3442
• [d7b4f759c5] - doc: typo fix in readme.md (Sam P Gallagher-Bishop) #3649
• [d410d5856d] - doc: fix wrong date and known issue in changelog.md (James M Snell) #3650
• [5a23bb59ef] - doc: rename iojs-* groups to nodejs-* (Steven R. Loomis) #3634
• [b3b55a5155] - doc: fix crypto spkac function descriptions (Jason Gerfen) #3614
• [bb20abb320] - doc: Updated streams simplified constructor API (Tom Gallacher) #3602
• [08ab9f35da] - doc: made code spans more visible in the API docs (phijohns) #3573
• [98762d2ae1] - doc: added what buf.copy returns (Manuel B) #3555
• [dfc2707097] - doc: fix function param order in assert doc (David Woods) #3533
• [d02365ba83] - doc: add note about timeout delay > TIMEOUT_MAX (Guilherme Souza) #3512
• [4a94c0a06f] - doc: add caveats of algs and key size in crypto (Shigeki Ohtsu) #3479
• [22bfe2297b] - doc: add method links in events.markdown (Alejandro Oviedo) #3187
• [38a5ae1285] - doc: stdout/stderr can block when directed to file (Ben Noordhuis) #3170
• [5689630c84] - docs: fs - change links to buffer encoding to Buffer class anchor (fansworld-claudio) #2796
• [948af717d5] - module: remove unnecessary JSON.stringify (Andres Suarez) #3578
• [486d287c1e] - repl: don't crash if cannot open history file (Evan Lucas) #3630
• [bf489691be] - repl: To exit, press ^C again or type .exit. (Hemanth.HM) #3368
• [550c606428] - src: Revert "nix stdin _readableState.reading" (Roman Reiss) #3490
• [07b57914e4] - test: use really invalid hostname (Sakthipriyan Vairamani) #3711
• [0fb40b4300] - test: Fix test-cluster-worker-exit.js for AIX (Imran Iqbal) #3666
• [2570cb79e5] - test: fix test-module-loading-error for musl (Hugues Malphettes) #3657
• [7009e019af] - test: fix test-net-persistent-keepalive for AIX (Imran Iqbal) #3646
• [c10f17fafd] - test: fix path to module for repl test on Windows (Michael Cornacchia) #3608
• [84f8eb7094] - test: add test-zlib-flush-drain (Myles Borins) #3534
• [75b4613f46] - test: enhance fs-watch-recursive test (Sakthipriyan Vairamani) #2599
• [1064eb6aa8] - util: use regexp instead of str.replace().join() (qinjia) #3689
• [1543c78c12] - zlib: only apply drain listener if given callback (Craig Cavalier) #3534
• [d1cedbd981] - zlib: pass kind to recursive calls to flush (Myles Borins) #3534

[MylesBorins]

Some commits that didn't land yet

• A number of commits from Add a new option to limit DH key size in tls connect node#1831
  • test: mark http-pipeline-flood flaky node#3616 relies on this
• [https://github.com/nodejs/node/commit/d8db75730f528cdd0e4629f528c97dc3de0543d6] - tls: add options argument to createSecurePair Secure pair fix node#2441
  • marked semver-minor
• [https://github.com/nodejs/node/commit/f6230b9b72e4e25e3177473ea904daf1968470bc] - test: remove flaky designation from ls-no-sslv3 test: remove flaky designation from ls-no-sslv3 node#3620
  • fix for a flaky test. I wanted to land this last in case there was a regression and it had to be rolled back
• [https://github.com/nodejs/node/commit/6b0c906e6badbba64611feb766d57b233b64e5f9] - tls: remove util and calls to util.format tls: remove util and calls to util.format node#3456
  • Likely ready to land, was requested it have time to on master first
• All three commits from AsyncWrap external API improvements node#3461 - AsyncWrap external API improvements
  • just wanted another person to verify before landing
• [https://github.com/nodejs/node/commit/57bce60da33b26d8e782c92fcd56f7af6ada8c4d] - child_process: don't fork bomb ourselves from -e child_process: don't fork bomb ourselves from -e node#3575
  • It was suggested this spend some time on v5 first.
• two commits from Fix flakiness of pipeflood test node#3636
  • This missed the LTS watch original, I added the label and was going to land it today if there were no objections
• [https://github.com/nodejs/node/commit/33827e3f6864872f357da6f9566f3c90b138c4ef] - cluster: remove handles when disconnecting worker cluster: remove handles when disconnecting worker node#3677
  • Ben suggested this wait for it to live on 5.x a bit before landing

Everything else has been on master for a week or less than a week although there are some PR's from that batch that can be considered

• a series of commits by @stefanmb fixing various crypto issues / tests
  • tls: Use SHA1 for sessionIdContext in FIPS mode node#3755
  • crypto: DSA parameter validation in FIPS mode node#3756
  • test: increase crypto strength for FIPS standard node#3758
  • test: stronger crypto in test fixtures node#3759
• A handful of doc fixes that are dead simple to port and don't require testing

Let me know if you want me to follow up on this, if I do land anything I'll chime in the thread so the above list can be updated

[MylesBorins]

I'm going to leave this commit open to reference new commits as they land on LTS. @rvagg once it has been added to the above list please feel free to remove it from here.

• nodejs/node@208de53 - doc: document release types in readme Release clarification and links node#3482
• nodejs/node@5254fda - doc: repl: add defineComand and displayPrompt doc: repl: add defineComand and displayPrompt node#3765
• nodejs/node@5254fda...9294523 - test: fix flaky test test-http-pipeline-flood Fix flakiness of pipeflood test node#3636
• nodejs/node@643d949 - docs: improve discoverability of Code of Conduct improve discovery of CoC node#3774
• nodejs/node@4bfa159 - doc: replace head of readme with updated text Release clarification and links node#3482
• nodejs/node@0c5429a - doc: clarify duplicate header handling doc: clarify duplicate headers in http.IncomingMessage node#3810
• nodejs/node@fc629c2 - doc: reword message.headers to indicate they are not read-only doc: reword message.headers node#3814
• nodejs/node@79220be7 - doc: address use of profanity in code of conduct doc: update code of conduct to address the use of profanity node#3827
• nodejs/node@ff992ffa - doc: consistent reference-style links doc: consistent reference-style links node#3845
• nodejs/node@c914516 - doc: sort repl alphabetically doc: sort repl alphabetically node#3859

[Fishrock123]

Btw, this is src:

• [935b8be8f6] - Add missing va_end before return (Ömer Fadıl Usta) #3565

[MylesBorins]

as 4.2.2 has been cut I suggest we close this issue