child_process: don't fork bomb ourselves from -e

[bnoordhuis]

Remove the -e argument from process.execArgv in child_process.fork()
to keep node -e 'require("child_process").fork("empty.js")' from
spawning itself recursively.

Fixes: #3574

R=@Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/643/

[cjihrig]

LGTM

[Trott]

LGTM

[rvagg]

suggesting this goes into v4.x-staging after having done some time in v5.0.0, @jasnell what do you think?

[jasnell]

Agreed but likely better to land it post v4.2.2

[bnoordhuis]

It's not a regression in any way (it's a buglet that apparently goes all the way back to v0.6) so it would IMO be perfectly acceptable to leave it out of LTS.

[jasnell]

@bnoordhuis .. noted! 👍

On Fri, Oct 30, 2015 at 9:55 AM, Ben Noordhuis notifications@github.com
wrote:

It's not a regression in any way (it's a buglet that apparently goes all
the way back to v0.6) so it would IMO be perfectly acceptable to leave it
out of LTS.

—
Reply to this email directly or view it on GitHub
#3575 (comment).

[MylesBorins]

@jasnell @bnoordhuis @rvagg has this spent enough time in 5.1.0?

[jasnell]

@thealphanerd ... I'd say yes.

[bnoordhuis]

Yes, I think so.

EDIT: I see you landed it a few minutes ago. :-)