Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable Clang-cl Windows builds #35433

Closed
wants to merge 12 commits into from
+113 −82
Closed

build: enable Clang-cl Windows builds #35433

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ff3a4ec
tools: hack gyp to generate clang-cl solutions
targos Jul 4, 2020
26e51ff
deps: add missing zlib includes
targos Jul 4, 2020
711a822
hack ICU
targos Sep 30, 2020
bbf0efc
disable some workflows
targos Oct 22, 2022
3ccb17d
remove macros
targos Oct 22, 2022
273cb2b
set clang to 1
targos Nov 20, 2022
6ec7554
fix pch
targos Nov 20, 2022
1f149ca
fix build on clangcl, except for v8 assembly (#9)
lemire Dec 15, 2023
d4fe780
fix: embed snapshot asm into a source file like v8 does
lemire Jan 3, 2024
9d7c136
fix: lib paths and remove unneeded masm
lemire Jan 3, 2024
1a5726a
fix: only build embedded.cc when under Windows. (#11)
lemire Jan 5, 2024
d5302f5
fix: only generate embedded.cc under Windows. (#12)
lemire Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hack ICU
  • Loading branch information
@targos
targos committed Apr 30, 2024
commit 711a822f831f8c46f5935280257d3b7c8769a56a
3 changes: 2 additions & 1 deletion deps/icu-small/source/tools/toolutil/pkg_genc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,8 +846,9 @@ getArchitecture(uint16_t *pCPU, uint16_t *pBits, UBool *pIsBigEndian, const char
// for all architectures though.
# if defined(_M_IX86)
*pCPU = IMAGE_FILE_MACHINE_I386;
// TODO: detect ARM64
# else
*pCPU = IMAGE_FILE_MACHINE_UNKNOWN;
*pCPU = IMAGE_FILE_MACHINE_AMD64;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for #34201

Comment on lines +849 to +851
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried an ARM64 build and got an error connected to these changes.

After some investigation, I found that dealing with a TODO: detect ARM64 added here would be tricky. This file is a part of a host project, thus it is always compiled for x64 in our case. Ideally, we'd use _M_ARM64/_M_AMD64 and set different IMAGE_FILE_MACHINE_... based on that in a target architecture project, but that cannot be used here.

What we can do, is add another option to genccode_host (genccode.c) that we'd use for setting the *pCPU. The issue with it is that the files I'd change in the process are part of the deps so we'd be making a floating patch on similar to the ones we have on V8, which is not great, but currently I see no other way (although there might be some).

# endif
# if defined(_M_IA64) || defined(_M_AMD64) || defined (_M_ARM64)
*pBits = 64; // Doesn't seem to be used for anything interesting though?
Expand Down