Repository navigation
ICU build issue with clang-cl #34201
Description
Activity
cc @nodejs/i18n
@targos have not heard of this, may be good to file an ICU bug upstream at https://unicode-org.atlassian.net //
@jefgen
may have to fall back to .c file builds for data if the assembly generayion is getting confused
I am not familiar with icu, which part involved into this ? Is unknown machine: 0 comes from icu code or clang ?
I think the problem comes from this file: https://github.com/nodejs/node/blob/a51436cbea0d216f260453321a15fdce72ee28d3/deps/icu-small/source/tools/toolutil/pkg_genc.cpp
During compilation, the following printf:
genccode: using architecture cpu=0 bits=64 big-endian=0
The value of 0 for cpu comes from here:
From the comment in the file:
// link.exe will link an IMAGE_FILE_MACHINE_UNKNOWN data-only .obj file
// no matter what architecture it is targeting (though other values are
// required to match). Unfortunately, the variable name decoration/mangling
// is slightly different on x86, which means we can't use the UNKNOWN type
// for all architectures though.I wonder if maybe the linker for clang doesn't handle IMAGE_FILE_MACHINE_UNKNOWN the same as the linker for MSVC...?
IIRC, the reason IMAGE_FILE_MACHINE_UNKNOWN was set, was to produce a generic .obj file that could be used for both x64 or ARM64, in order to support cross-compiling for ARM64 on x64.
If you don't need to cross-compile ARM64 (on a x64 host) then perhaps this could be changed to set an explicit CPU arch when building with clang.
Perhaps something like:
#elif U_PLATFORM_HAS_WIN32_API
// Windows always runs in little-endian mode.
*pIsBigEndian = FALSE;
// Note: The various _M_<arch> macros are predefined by the MSVC compiler based
// on the target compilation architecture.
// https://docs.microsoft.com/cpp/preprocessor/predefined-macros
// link.exe will link an IMAGE_FILE_MACHINE_UNKNOWN data-only .obj file
// no matter what architecture it is targeting (though other values are
// required to match). Unfortunately, the variable name decoration/mangling
// is slightly different on x86, which means we can't use the UNKNOWN type
// for all architectures though.
# if defined(_M_IX86)
*pCPU = IMAGE_FILE_MACHINE_I386;
# else
#ifndef (__clang__)
// the linker for clang-cl doesn't work with unknown.
*pCPU = IMAGE_FILE_MACHINE_UNKNOWN;
#elif defined(_M_AMD64)
*pCPU = IMAGE_FILE_MACHINE_AMD64;
#endif /* ifndef (__clang__) */
# endifIf you don't need to cross-compile ARM64 (on a x64 host)
Unfortunately, we do cross-compile ARM64 on x64 hosts.
I'm experimenting with Visual Studio's Clang support and have an issue with ICU:
There's only one line with an error while building
tools\icu\icudata.vcxproj/cc @srl295
Diff to get there