Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: avoid Object.create(null) for Http2ServerRequest.headers #33183

Closed
wants to merge 4 commits into from
Closed

http2: avoid Object.create(null) for Http2ServerRequest.headers #33183

wants to merge 4 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 1, 2020 •
edited
Loading

Currently http2.Http2ServerRequest.headers returns headers which is initialized by Object.create(null) which is a different behaviour than what is seen in http.

Refs: #29829

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label May 1, 2020
@jasnell
Copy link
Member

jasnell commented May 1, 2020

The use of Object.create(null) in http/2 is intentional. For HTTP/1, the reason we do not use Object.create(null) for headers is because it would break too much code but it would have been preferable. I don't think this is one we want to change. A code comment to that effect would be good.

BridgeAR
BridgeAR approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % linter error.

@addaleax
Copy link
Member

Landed in ee87567 :)

@addaleax addaleax closed this May 19, 2020
addaleax pushed a commit that referenced this pull request May 19, 2020
@rexagod @addaleax
http2: comment on usage of Object.create(null)
ee87567 
Refs: #29829

PR-URL: #33183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request May 21, 2020
@rexagod @codebytere
http2: comment on usage of Object.create(null)
e7aac29 
Refs: #29829

PR-URL: #33183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rexagod rexagod mentioned this pull request Jun 6, 2020
Open
32 tasks
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@rexagod @codebytere
http2: comment on usage of Object.create(null)
5da952f 
Refs: #29829

PR-URL: #33183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@rexagod @codebytere
http2: comment on usage of Object.create(null)
fa4a37c 
Refs: nodejs#29829

PR-URL: nodejs#33183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rexagod @jasnell @addaleax @cjihrig @BridgeAR @nodejs-github-bot