Skip to content

Commit ee87567

Browse files
rexagodaddaleax
authored andcommitted
http2: comment on usage of Object.create(null)
Refs: #29829 PR-URL: #33183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 0e92ae6 commit ee87567

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/internal/http2/compat.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,9 @@ class Http2ServerRequest extends Readable {
287287
closed: false,
288288
didRead: false,
289289
};
290+
// Headers in HTTP/1 are not initialized using Object.create(null) which,
291+
// although preferable, would simply break too much code. Ergo header
292+
// initialization using Object.create(null) in HTTP/2 is intentional.
290293
this[kHeaders] = headers;
291294
this[kRawHeaders] = rawHeaders;
292295
this[kTrailers] = {};

0 commit comments

Comments
 (0)