doc: remove non-existent entry-type flag#27678
Closed
dnalborczyk wants to merge 2 commits intonodejs:masterfrom
Closed
doc: remove non-existent entry-type flag#27678dnalborczyk wants to merge 2 commits intonodejs:masterfrom
dnalborczyk wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
previously approved these changes
May 13, 2019
Trott
reviewed
May 13, 2019
Trott
reviewed
May 13, 2019
BridgeAR
approved these changes
May 13, 2019
Member
|
LGTM with the comments addressed. Refs: #27184 |
guybedford
approved these changes
May 13, 2019
Trott
approved these changes
May 13, 2019
Trott
added
the
author ready
trivikr
approved these changes
May 15, 2019
Collaborator
4 tasks
Contributor
|
Landed in 545b59e. |
guybedford
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #27678 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2019
PR-URL: #27678 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passespossible leftover from: #27184