esm: replace --entry-type with --input-type #27184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
GeoffreyBooth
force-pushed
the
flag-for-string-input-only
branch
from
8e92ab2 to
a4047d3
Compare
hybrist
reviewed
Apr 11, 2019
doc/api/errors.md
Outdated
Contributor
There was a problem hiding this comment.
Was this left in on purpose?
Member
Author
There was a problem hiding this comment.
Yes, see the section head:
These errors have never been released, but had been present on master between
releases.
hybrist
approved these changes
Apr 11, 2019
targos
reviewed
Apr 11, 2019
targos
approved these changes
Apr 11, 2019
devsnek
added
esm
joyeecheung
approved these changes
Apr 11, 2019
ljharb
approved these changes
Apr 11, 2019
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
the modules group achieved consensus on this change, so we do support it
GeoffreyBooth
force-pushed
the
flag-for-string-input-only
branch
from
c73e3a6 to
560c745
Compare
Collaborator
GeoffreyBooth
force-pushed
the
flag-for-string-input-only
branch
3 times, most recently
from
ab4712a to
fb9d934
Compare
BridgeAR
approved these changes
Apr 15, 2019
BridgeAR
added
the
author ready
Collaborator
Collaborator
Collaborator
MylesBorins
force-pushed
the
flag-for-string-input-only
branch
from
d2eaa1e to
3e037fa
Compare
Collaborator
Contributor
|
landed in 96e46d3 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2019
New flag is for string input only PR-URL: #27184 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Apr 23, 2019
chjj
added a commit
to chjj/bthreads
that referenced
this pull request
Apr 30, 2019
chjj
added a commit
to bcoin-org/bmocha
that referenced
this pull request
May 3, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per nodejs/modules#300 (comment), this PR replaces
--entry-typewith--input-type, a flag just like--entry-typebut only for--eval,--printandSTDIN.This way we still provide a way to use ESM in those non-file inputs, but we’re removing the footgun that is
--entry-typein its current form. To use ESM in files, the files need to end in.mjsor be in a"type": "module"package scope.Tests and docs updated.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes