Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test-cpu-prof in debug builds with code cache #27308

Closed
wants to merge 3 commits into from
Closed

test: skip test-cpu-prof in debug builds with code cache #27308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8998165
test: skip test-cpu-prof in debug builds with code cache
joyeecheung Apr 19, 2019
c26bf3f
fixup! test: skip test-cpu-prof in debug builds with code cache
joyeecheung Apr 19, 2019
f7d81e5
fixup! fixup! test: skip test-cpu-prof in debug builds with code cache
joyeecheung Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/sequential/test-cpu-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
// This tests that --cpu-prof and --cpu-prof-path works.

const common = require('../common');
if (process.features.debug &&
process.config.variables.node_code_cache_path === 'yes') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATM this is not the best predicate for embedded code-cache...
I've submitted #27311 to fix the value, and this predicate (it could be any non '' value if combined with the previous manual embedding technique)

// FIXME(joyeecheung): the profiler crashes when code cache
// is enabled in debug builds.
common.skip('--cpu-prof does not work in debug builds with code cache');
}

const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();

Expand Down