Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: improve embedded code-cache detection #27311

Merged
merged 1 commit into from
Apr 22, 2019
Merged

build: improve embedded code-cache detection #27311

merged 1 commit into from
Apr 22, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 19, 2019 •
edited
Loading

Follow up to #27308

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 19, 2019
@refack refack requested a review from joyeecheung April 19, 2019 13:44
@refack refack mentioned this pull request Apr 19, 2019
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22570/

@refack
Copy link
Contributor Author

refack commented Apr 19, 2019

Added process.features.code_cache field based on compile time constant, and not build configuration.

@refack refack added the process Issues and PRs related to the process subsystem. label Apr 19, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refack refack self-assigned this Apr 20, 2019
@refack
Copy link
Contributor Author

refack commented Apr 20, 2019

Ping @nodejs/build-files @nodejs/process

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
BridgeAR
BridgeAR reviewed Apr 21, 2019
View reviewed changes
configure.py Outdated Show resolved Hide resolved
lib/internal/bootstrap/node.js Show resolved Hide resolved
@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
@nodejs nodejs deleted a comment from nodejs-github-bot Apr 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22602/

@refack
build: improve embedded code-cache detection
5aaf666 
PR-URL: nodejs#27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack refack merged commit 5aaf666 into nodejs:master Apr 22, 2019
@refack refack deleted the fix-config-code-cache-bug branch April 22, 2019 18:51
@refack refack removed their assignment Apr 22, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 12, 2024
Merged
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2024
@aduh95
doc: fix history of process.features
421977c 
PR-URL: #54982
Refs: aa0308d
Refs: 9010f5f
Refs: 52a40e0
Refs: b3ef289
Refs: #2564
Refs: #25819
Refs: #27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
doc: fix history of process.features
f2d74a2 
PR-URL: #54982
Refs: aa0308d
Refs: 9010f5f
Refs: 52a40e0
Refs: b3ef289
Refs: #2564
Refs: #25819
Refs: #27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
doc: fix history of process.features
cf6151c 
PR-URL: nodejs#54982
Refs: nodejs@aa0308d
Refs: nodejs@9010f5f
Refs: nodejs@52a40e0
Refs: nodejs@b3ef289
Refs: nodejs#2564
Refs: nodejs#25819
Refs: nodejs#27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@joyeecheung joyeecheung joyeecheung approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@refack @nodejs-github-bot @joyeecheung @richardlau @BridgeAR @mihalskiy