Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 7.4.288.21 #27265

Closed
wants to merge 2 commits into from
Closed

deps: patch V8 to 7.4.288.21 #27265

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

Refs: v8/v8@7.4.288.18...7.4.288.21

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3275

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22508/

@mmarchini
Copy link
Contributor Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2227/

BridgeAR
BridgeAR approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos
Copy link
Member

targos commented Apr 16, 2019

What happened to postmortem metadata 😱

20:33:57 not ok 2 v8-updates/test-postmortem-metadata
20:33:57   ---
20:33:57   duration_ms: 0.169
20:33:57   severity: fail
20:33:57   exitcode: 1
20:33:57   stack: |-
20:33:57     assert.js:89
20:33:57       throw new AssertionError(obj);
20:33:57       ^
20:33:57     
20:33:57     AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_bit_field3_is_dictionary_map_shift,v8dbg_bit_field3_number_of_own_descriptors_shift,v8dbg_class_Code__instruction_size__int,v8dbg_class_Code__instruction_start__uintptr_t,v8dbg_class_ConsString__first__String,v8dbg_class_ConsString__second__String,v8dbg_class_FixedArray__data__uintptr_t,v8dbg_class_FixedArrayBase__length__SMI,v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_HeapNumber__value__double,v8dbg_class_HeapObject__map__Map,v8dbg_class_JSArray__length__Object,v8dbg_class_JSArrayBuffer__backing_store__uintptr_t,v8dbg_class_JSArrayBuffer__byte_length__size_t,v8dbg_class_JSArrayBufferView__buffer__Object,v8dbg_class_JSArrayBufferView__byte_length__size_t,v8dbg_class_JSArrayBufferView__byte_offset__size_t,v8dbg_class_JSDate__value__Object,v8dbg_class_JSFunction__context__Context,v8dbg_class_JSFunction__shared__SharedFunctionInfo,v8dbg_class_JSObject__elements__Object,v8dbg_class_JSObject__internal_fields__uintptr_t,v8dbg_class_JSReceiver__raw_properties_or_hash__Object,v8dbg_class_JSRegExp__source__Object,v8dbg_class_Map__bit_field3__int,v8dbg_class_Map__constructor_or_backpointer__Object,v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char,v8dbg_class_Map__instance_type__uint16_t,v8dbg_class_Map__instance_descriptors_offset,v8dbg_class_Map__instance_size_in_words__char,v8dbg_class_Oddball__kind_offset__int,v8dbg_class_Script__line_ends__Object,v8dbg_class_Script__line_offset__SMI,v8dbg_class_Script__name__Object,v8dbg_class_Script__source__Object,v8dbg_class_SeqOneByteString__chars__char,v8dbg_class_SeqTwoByteString__chars__char,v8dbg_class_SharedFunctionInfo__function_data__Object,v8dbg_class_SharedFunctionInfo__flags__int,v8dbg_class_UncompiledData__end_position__int32_t,v8dbg_class_UncompiledData__inferred_name__String,v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t,v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object,v8dbg_class_SharedFunctionInfo__script_or_debug_info__Object,v8dbg_class_UncompiledData__start_position__int32_t,v8dbg_class_SlicedString__offset__SMI,v8dbg_class_SlicedString__parent__String,v8dbg_class_String__length__int32_t,v8dbg_class_ThinString__actual__String,v8dbg_context_idx_scope_info,v8dbg_context_idx_prev,v8dbg_context_min_slots,v8dbg_frametype_ArgumentsAdaptorFrame,v8dbg_frametype_ConstructEntryFrame,v8dbg_frametype_ConstructFrame,v8dbg_frametype_EntryFrame,v8dbg_frametype_ExitFrame,v8dbg_frametype_InternalFrame,v8dbg_frametype_OptimizedFrame,v8dbg_frametype_StubFrame,v8dbg_jsarray_buffer_was_detached_mask,v8dbg_jsarray_buffer_was_detached_shift,v8dbg_namedictionary_prefix_start_index,v8dbg_namedictionaryshape_entry_size,v8dbg_namedictionaryshape_prefix_size,v8dbg_off_fp_args,v8dbg_off_fp_context,v8dbg_off_fp_function,v8dbg_prop_attributes_mask,v8dbg_prop_attributes_shift,v8dbg_prop_attributes_DONT_ENUM,v8dbg_prop_attributes_DONT_ENUM,v8dbg_prop_attributes_NONE,v8dbg_prop_attributes_READ_ONLY,v8dbg_prop_desc_details,v8dbg_prop_desc_key,v8dbg_prop_desc_size,v8dbg_prop_desc_value,v8dbg_prop_index_mask,v8dbg_prop_index_shift,v8dbg_prop_kind_mask,v8dbg_prop_kind_Accessor,v8dbg_prop_kind_Data,v8dbg_prop_location_mask,v8dbg_prop_location_shift,v8dbg_prop_location_Descriptor,v8dbg_prop_location_Field,v8dbg_prop_representation_double,v8dbg_prop_representation_mask,v8dbg_prop_representation_shift,v8dbg_scopeinfo_idx_first_vars,v8dbg_scopeinfo_idx_ncontextlocals,v8dbg_scopeinfo_idx_nparams,v8dbg_type_Code__CODE_TYPE,v8dbg_type_FixedArray__FIXED_ARRAY_TYPE,v8dbg_type_HeapNumber__HEAP_NUMBER_TYPE,v8dbg_type_JSArray__JS_ARRAY_TYPE,v8dbg_type_JSArrayBuffer__JS_ARRAY_BUFFER_TYPE,v8dbg_type_JSDate__JS_DATE_TYPE,v8dbg_type_JSFunction__JS_FUNCTION_TYPE,v8dbg_type_JSGlobalObject__JS_GLOBAL_OBJECT_TYPE,v8dbg_type_JSGlobalProxy__JS_GLOBAL_PROXY_TYPE,v8dbg_type_JSObject__JS_OBJECT_TYPE,v8dbg_type_JSRegExp__JS_REGEXP_TYPE,v8dbg_type_JSTypedArray__JS_TYPED_ARRAY_TYPE,v8dbg_type_Map__MAP_TYPE,v8dbg_type_Oddball__ODDBALL_TYPE,v8dbg_type_Script__SCRIPT_TYPE,v8dbg_type_SharedFunctionInfo__SHARED_FUNCTION_INFO_TYPE,v8dbg_APIObjectType,v8dbg_ConsStringTag,v8dbg_ExternalStringTag,v8dbg_FirstNonstringType,v8dbg_HeapObjectTag,v8dbg_HeapObjectTagMask,v8dbg_OddballException,v8dbg_OddballFalse,v8dbg_OddballNull,v8dbg_OddballTheHole,v8dbg_OddballTrue,v8dbg_OddballUndefined,v8dbg_OddballUninitialized,v8dbg_OneByteStringTag,v8dbg_SystemPointerSize,v8dbg_SystemPointerSizeLog2,v8dbg_TaggedSize,v8dbg_TaggedSizeLog2,v8dbg_SeqStringTag,v8dbg_SlicedStringTag,v8dbg_SmiShiftSize,v8dbg_SmiTag,v8dbg_SmiTagMask,v8dbg_SpecialAPIObjectType,v8dbg_StringEncodingMask,v8dbg_StringRepresentationMask,v8dbg_ThinStringTag,v8dbg_TwoByteStringTag

@mmarchini
Copy link
Contributor Author

That's very weird. I'll take a look.

@mmarchini
Copy link
Contributor Author

Caused by: #23027

I'll add a commit to fix this.

@mmarchini
test: fix postmortem metadata test
e1dad2c 
Recent changes to spawnSync (nodejs#23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22515/

@mmarchini
Copy link
Contributor Author

New V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2228/

@mmarchini mmarchini mentioned this pull request Apr 16, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22516/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22549/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22553/

@mmarchini
Copy link
Contributor Author

CI is green. Landing

@mmarchini
Copy link
Contributor Author

Landed in a7d7d4d...8712edf

@mmarchini mmarchini closed this Apr 18, 2019
mmarchini added a commit that referenced this pull request Apr 18, 2019
@mmarchini
deps: patch V8 to 7.4.288.21
7f29117 
Refs: v8/v8@7.4.288.18...7.4.288.21

PR-URL: #27265
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mmarchini added a commit that referenced this pull request Apr 18, 2019
@mmarchini
test: fix postmortem metadata test
8712edf 
Recent changes to spawnSync (#23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.

PR-URL: #27265
Refs: v8/v8@7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmarchini @nodejs-github-bot @targos @cjihrig @BridgeAR