Skip to content

Commit

Permalink
test: fix postmortem metadata test
Browse files Browse the repository at this point in the history
Recent changes to spawnSync (#23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.

PR-URL: #27265
Refs: v8/v8@7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
mmarchini committed Apr 18, 2019
1 parent 7f29117 commit 8712edf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/v8-updates/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if (common.isAIX)
if (common.isOpenBSD)
common.skip('no v8 debug symbols on OpenBSD');

const nm = spawnSync('nm', args);
const nm = spawnSync('nm', args, { maxBuffer: Infinity });

if (nm.error && nm.error.errno === 'ENOENT')
common.skip('nm not found on system');
Expand Down

0 comments on commit 8712edf

Please sign in to comment.