src: move AsyncResource impl out of public header

[bnoordhuis]

Implementing the methods out-of-line (i.e., not inline) means we can fix
bugs and have already compiled add-ons pick up the fixes automatically,
something that doesn't work when the methods are inline because then
they get compiled into the add-on instead of the node binary.

CI: https://ci.nodejs.org/job/node-test-pull-request/21029/

[nodejs-github-bot]

@bnoordhuis sadly an error occured when I tried to trigger a build :(

[addaleax]

I don’t quite understand the Windows CI failure (there doesn’t seem to be information about where in our source it is coming from), but it seems related.

[bnoordhuis]

Rebase + new CI to check if it's actually a persistent issue: https://ci.nodejs.org/job/node-test-pull-request/21086/

[refack]

Windows compile fail is triggered by the NODE_EXTERN from line
https://github.com/nodejs/node/blob/a3dce1b5e115e7c08c2f3e2e62ede6ba3c1d93d5/src/node.h#L703
by line
https://github.com/nodejs/node/blob/a3dce1b5e115e7c08c2f3e2e62ede6ba3c1d93d5/src/node.h#L739

D:\code\prws\deps\v8\include\v8.h(631): error C2440: '=': cannot convert from 'v8::Primitive *' to 'O *volatile ' [D:\code\prws\node_lib.vcxproj]
          with
          [
              O=v8::Object
          ]
  D:\code\prws\deps\v8\include\v8.h(631): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
  D:\code\prws\deps\v8\include\v8.h(627): note: see reference to function template instantiation 'void v8::NonCopyablePersistentTraits<T>::Uncompilable<v8::Object>(void)' being compiled
          with
          [
              T=v8::Object
          ]

[BridgeAR]

Ping @bnoordhuis

[bnoordhuis]

Sorry, missed @refack's comment. Feedback incorporated. New CI: https://ci.nodejs.org/job/node-test-pull-request/21781/

[BridgeAR]

Seems like it does compile on Windows now. There's just one test failing that might be related: https://ci.nodejs.org/job/node-test-binary-windows/24767/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/testReport/junit/(root)/test/parallel_test_inspect_async_hook_setup_at_inspect/

[refack]

Seems like it does compile on Windows now. There's just one test failing that might be related:

Probably it's just being flaky #26798

Resume: https://ci.nodejs.org/job/node-test-pull-request/21814

[BridgeAR]

Landed in eb2dccb 🎉