investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI

[Trott]

Getting this non-stop in win2008r2 VS 2017 in CI.

https://ci.nodejs.org/job/node-test-binary-windows/24664/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3/console

test-rackspace-win2008r2-x64-3

21:36:40 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
21:36:40   ---
21:36:40   duration_ms: 0.516
21:36:40   severity: fail
21:36:40   exitcode: 1
21:36:40   stack: |-
21:36:40     [test] Connecting to a child Node process
21:36:40     [test] Testing /json/list
21:36:40     [err] Debugger listening on ws://127.0.0.1:52961/4afeaa3a-d321-4eaf-9ddd-2954cee7e45e
21:36:40     [err] For help, see: https://nodejs.org/en/docs/inspector
21:36:40     [err] 
21:36:40     [err] Debugger attached.
21:36:40     [err] 
21:36:40     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
21:36:40     [err] 
21:36:40     [err]  1: 000000013F5192FF napi_wrap+84399
21:36:40     [err] 
21:36:40     [err]  2: 000000013F4D0BD6 uv_loop_fork+44166
21:36:40     [err]  3: 000000013F4D1726 uv_loop_fork+47062
21:36:40     [err]  4: 000000013F4D1309 uv_loop_fork+46009
21:36:40     [err]  5: 000000013F4387A3 std::basic_ios<char,std::char_traits<char> >::imbue+76147
21:36:40     [err]  6: 000000013FA4EC27 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
21:36:40     [err]  7: 000000013FA2D64C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
21:36:40     [err]  8: 000000013FA16CFF v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
21:36:40     [err]  9: 000000013FA0FFFF v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
21:36:40     [err] 10: 000000013FA00B1D v8::internal::Factory::zero_string+23837
21:36:40     [err] 11: 000000013F805063 v8_inspector::V8InspectorSession::canDispatchMethod+675
21:36:40     [err] 12: 000000013F4393DA std::basic_ios<char,std::char_traits<char> >::imbue+79274
21:36:40     [err] 13: 000000013F4373B6 std::basic_ios<char,std::char_traits<char> >::imbue+71046
21:36:40     [err] 14: 000000013F4273CE std::basic_ios<char,std::char_traits<char> >::imbue+5534
21:36:40     [err] 15: 000000013F42642E std::basic_ios<char,std::char_traits<char> >::imbue+1534
21:36:40     [err] 16: 000000013F426F4B std::basic_ios<char,std::char_traits<char> >::imbue+4379
21:36:40     [err] 17: 000000013F427557 std::basic_ios<char,std::char_traits<char> >::imbue+5927
21:36:40     [err] 18: 000000013F8D4465 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
21:36:40     [err] 19: 000000013F8B121E v8::internal::StackGuard::HandleInterrupts+398
21:36:40     [err] 20: 000000013FBA3DB5 v8::internal::OptimizingCompileDispatcher::Unblock+53381
21:36:40     [err] 21: 000000014003D34F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
21:36:40     [err] 
21:36:40     { Error: read ECONNRESET
21:36:40         at TCP.onStreamRead (internal/stream_base_commons.js:178:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
21:36:40     1
21:36:40   ...

[refack]

I have seen this multiple times in the last 48h but it's a flake:
This one failed: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25676/
Resumed and passed: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25687/

specifics:

1. • Job: https://ci.nodejs.org/job/node-test-binary-windows/24660/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3/
   • Worker: https://ci.nodejs.org/computer/test-rackspace-win2008r2-x64-3/
2. • Job: https://ci.nodejs.org/job/node-test-binary-windows/24671/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3
   • Worker: https://ci.nodejs.org/computer/test-rackspace-win2008r2-x64-3/
   • JUnit report

[refack]

Ping @nodejs/v8-inspector

[Trott]

https://ci.nodejs.org/job/node-test-binary-windows/24702/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/console

test-rackspace-win2008r2-x64-6

00:17:11 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
00:17:11   ---
00:17:11   duration_ms: 0.614
00:17:11   severity: fail
00:17:11   exitcode: 1
00:17:11   stack: |-
00:17:11     [test] Connecting to a child Node process
00:17:11     [test] Testing /json/list
00:17:11     [err] Debugger listening on ws://127.0.0.1:57632/cfedc474-b361-4187-80ed-1b68bdbd10cd
00:17:11     [err] For help, see: https://nodejs.org/en/docs/inspector
00:17:11     [err] 
00:17:11     [err] Debugger attached.
00:17:11     [err] 
00:17:11     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
00:17:11     [err] 
00:17:11     [err]  1: 000000013F44A0AF napi_wrap+84447
00:17:11     [err]  2: 000000013F4018C6 uv_loop_fork+44166
00:17:11     [err]  3: 000000013F402416 uv_loop_fork+47062
00:17:11     [err]  4: 000000013F401FF9 uv_loop_fork+46009
00:17:11     [err]  5: 000000013F3692C3 std::basic_ios<char,std::char_traits<char> >::imbue+76067
00:17:11     [err] 
00:17:11     [err]  6: 000000013F97F7F7 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
00:17:11     [err]  7: 000000013F95E21C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
00:17:11     [err]  8: 000000013F9478CF v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
00:17:11     [err]  9: 000000013F940BCF v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
00:17:11     [err] 10: 000000013F9316ED v8::internal::Factory::zero_string+23837
00:17:11     [err] 11: 000000013F735C33 v8_inspector::V8InspectorSession::canDispatchMethod+675
00:17:11     [err] 12: 000000013F369EFA std::basic_ios<char,std::char_traits<char> >::imbue+79194
00:17:11     [err] 13: 000000013F367ED6 std::basic_ios<char,std::char_traits<char> >::imbue+70966
00:17:11     [err] 14: 000000013F357F3E std::basic_ios<char,std::char_traits<char> >::imbue+5534
00:17:11     [err] 15: 000000013F356F9E std::basic_ios<char,std::char_traits<char> >::imbue+1534
00:17:11     [err] 16: 000000013F357ABB std::basic_ios<char,std::char_traits<char> >::imbue+4379
00:17:11     [err] 17: 000000013F3580C7 std::basic_ios<char,std::char_traits<char> >::imbue+5927
00:17:11     [err] 18: 000000013F805035 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
00:17:11     [err] 
00:17:11     [err] 19: 000000013F7E1DEE v8::internal::StackGuard::HandleInterrupts+398
00:17:11     [err] 20: 000000013FAD4985 v8::internal::OptimizingCompileDispatcher::Unblock+53381
00:17:11     [err] 21: 000000013FF6DF1F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
00:17:11     [err] 
00:17:11     { Error: read ECONNRESET
00:17:11         at TCP.onStreamRead (internal/stream_base_commons.js:182:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
00:17:11     1
00:17:11   ...

[refack]

Running 100 x python tools\test.py -p tap parallel/test-inspect-async-hook-setup-at-inspect begets:

100   OK: 63   NOT OK: 37   TOTAL: 100

/CC @nodejs/testing @nodejs/n-api

[refack]

Bisecting got me to the range of commits that landed on 2019-03-18
between
ed2c696 - https://ci.nodejs.org/job/node-stress-single-test/2176/nodes=win2008r2-vs2017/
a91d36f - https://ci.nodejs.org/job/node-stress-single-test/2179/
and
993bdff - https://ci.nodejs.org/job/node-stress-single-test/2177/nodes=win2008r2-vs2017/

993bdff...a91d36f

I'm off, if anyone want to continue.

[refack]

pinning this since it has ~50% probability of failing for a CI job.

[joyeecheung]

I cannot seem to identify the first CI run this appeared (some historical jobs are cleaned). It might be related to #26602