Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix the arguments order in assert.strictEqual #24610

Closed
wants to merge 1 commit into from
Closed

test: fix the arguments order in assert.strictEqual #24610

wants to merge 1 commit into from

Conversation

sigwyg
Copy link

@sigwyg sigwyg commented Nov 24, 2018

I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: fix the arguments order in assert.strictEqual
9053daf 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

potentially duplicate of #24592

@sigwyg
Copy link
Author

sigwyg commented Nov 24, 2018 •
edited
Loading

Oops! This PR Closing...

@sigwyg sigwyg closed this Nov 24, 2018
@sigwyg sigwyg deleted the sigwyg-fixed-strictEqual branch November 24, 2018 07:55
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 25, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sigwyg @gireeshpunathil @addaleax @nodejs-github-bot