Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix arguments order in assert.strictEqual #24592

Closed
wants to merge 1 commit into from
Closed

test: fix arguments order in assert.strictEqual #24592

wants to merge 1 commit into from

Conversation

na9amura
Copy link
Contributor

@na9amura na9amura commented Nov 24, 2018 •
edited
Loading

fix arguments order to be assert.strictEqual(actual, expected)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@ronkorving ronkorving added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
This was referenced Nov 24, 2018
Closed
Closed
@na9amura
Copy link
Contributor Author

I attend Code and Learn program on Node fest 2018 in Japan. As I raised hand later, I close my PR.

@na9amura na9amura closed this Nov 24, 2018
@na9amura na9amura deleted the fix-strict-equal-arguments-order branch November 24, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@na9amura @addaleax @gireeshpunathil @ronkorving @nodejs-github-bot