test: improve reliability of test-gc-http-client #23087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-gc-http-client is resource-intensive. It times out a lot on CI. Move to sequential. Fixes: nodejs#22336
|
For both this and #23086, can you remove the |
addaleax
approved these changes
Sep 25, 2018
joyeecheung
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
Same as @addaleax , this should likely to help making the test break less often but does not really fix it AFAICT
trivikr
approved these changes
Sep 26, 2018
|
Landed in 7d03ff1. |
danbev
pushed a commit
that referenced
this pull request
Sep 26, 2018
test-gc-http-client is resource-intensive. It times out a lot on CI. Move to sequential. Approved for fast-tracking by: Anna Henningsen <anna@addaleax.net> Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: #23087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
test-gc-http-client is resource-intensive. It times out a lot on CI. Move to sequential. Approved for fast-tracking by: Anna Henningsen <anna@addaleax.net> Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: #23087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.
Fixes: #22336
Labeling fast-track to fix flaky CI and because this is awfully easy to undo if someone comes up with a better solution. Please 👍 to approve fast-tracking.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes