Skip to content

Investigate flaky parallel/test-gc-http-client #22336

Closed
Closed
Investigate flaky parallel/test-gc-http-client#22336
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@Trott
Trott
opened on Aug 15, 2018
  • Version: 11.0.0-pre (master)
  • Platform: freebsd11-x64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-freebsd/19681/nodes=freebsd11-x64/console

00:08:04 not ok 694 parallel/test-gc-http-client
00:08:04   ---
00:08:04   duration_ms: 0.545
00:08:04   severity: fail
00:08:04   exitcode: 1
00:08:04   stack: |-
00:08:04     We should do 500 requests
00:08:04     Done: 0/500
00:08:04     Collected: 0/154
00:08:04     events.js:167
00:08:04           throw er; // Unhandled 'error' event
00:08:04           ^
00:08:04     
00:08:04     Error: connect ECONNRESET 127.0.0.1:15615 - Local (127.0.0.1:27660)
00:08:04         at internalConnect (net.js:933:16)
00:08:04         at defaultTriggerAsyncIdScope (internal/async_hooks.js:294:19)
00:08:04         at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
00:08:04         at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:62:10)
00:08:04     Emitted 'error' event at:
00:08:04         at Socket.socketErrorListener (_http_client.js:399:9)
00:08:04         at Socket.emit (events.js:182:13)
00:08:04         at emitErrorNT (internal/streams/destroy.js:82:8)
00:08:04         at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
00:08:04         at process._tickCallback (internal/process/next_tick.js:63:19)
00:08:04   ...

Activity

  1. joyeecheung commented on Aug 15, 2018

    @joyeecheung
    joyeecheung
    on Aug 15, 2018
    Member

    This also timeouts from time to time. In the last 100 runs:

    Reason     parallel/test-gc-http-client
Type       JS_TEST_FAILURE
Failed PR  5 (#22291, #22289, #22286, #22074, #22152)
Appeared   test-digitalocean-ubuntu1604_sharedlibs_container-x64-10, test-digitalocean-freebsd11-x64-1, test-digitalocean-ubuntu1604_sharedlibs_container-x64-9, test-digitalocean-ubuntu1604_sharedlibs_container-x64-8, test-digitalocean-ubuntu1604_sharedlibs_container-x64-7
First CI   https://ci.nodejs.org/job/node-test-pull-request/16401/
Last CI    https://ci.nodejs.org/job/node-test-pull-request/16420/

Example:

not ok 759 parallel/test-gc-http-client
  ---
  duration_ms: 480.47
  severity: fail
  exitcode: -15
  stack: |-
    timeout
    We should do 500 requests
    Done: 0/500
    Collected: 0/11
    Done: 0/500
    Collected: 0/22
    Done: 0/500
    Collected: 0/33
    Done: 0/500
    Collected: 0/44
    Done: 11/500
    Collected: 0/55
    Done: 22/500
    Collected: 0/66
    Done: 33/500
    Collected: 11/77
    Done: 44/500
    Collected: 22/88
    Done: 55/500
    Collected: 33/99
    Done: 66/500
    Coll...
  2. maclover7
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Aug 15, 2018

  3. Trott commented on Aug 16, 2018

    @Trott
    Trott
    on Aug 16, 2018
    MemberAuthor

    Again today: https://ci.nodejs.org/job/node-test-commit-freebsd/19713/nodes=freebsd11-x64/console

    03:34:55 not ok 728 parallel/test-gc-http-client
03:34:55   ---
03:34:55   duration_ms: 0.398
03:34:55   severity: fail
03:34:55   exitcode: 1
03:34:55   stack: |-
03:34:55     We should do 500 requests
03:34:55     Done: 0/500
03:34:55     Collected: 0/198
03:34:55     events.js:167
03:34:55           throw er; // Unhandled 'error' event
03:34:55           ^
03:34:55     
03:34:55     Error: connect ECONNRESET 127.0.0.1:65483 - Local (127.0.0.1:10142)
03:34:55         at internalConnect (net.js:933:16)
03:34:55         at defaultTriggerAsyncIdScope (internal/async_hooks.js:294:19)
03:34:55         at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
03:34:55         at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:62:10)
03:34:55     Emitted 'error' event at:
03:34:55         at Socket.socketErrorListener (_http_client.js:399:9)
03:34:55         at Socket.emit (events.js:182:13)
03:34:55         at emitErrorNT (internal/streams/destroy.js:82:8)
03:34:55         at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
03:34:55         at process._tickCallback (internal/process/next_tick.js:63:19)
03:34:55   ...
  4. BridgeAR
    added
    httpIssues and PRs related to the http subsystem.
    on Aug 17, 2018

  5. BridgeAR commented on Aug 17, 2018

    @BridgeAR
    BridgeAR
    on Aug 17, 2018
    Member

    I just had a look at this one and I opened a PR as fix.

  6. BridgeAR
    added a commit that references this issue on Aug 19, 2018

    test: harden test-gc-http-client

    262fc9f
  7. joyeecheung
    closed this as completedin 79642aeon Aug 20, 2018
  8. targos
    added a commit that references this issue on Aug 21, 2018

    test: harden test-gc-http-client

    73c9592

  9. refack commented on Aug 30, 2018

    @refack
    refack
    on Aug 30, 2018
    Contributor

    Still there - https://ci.nodejs.org/job/node-test-commit-freebsd/20132/nodes=freebsd11-x64/testReport/(root)/test/parallel_test_gc_http_client/
    host: test-digitalocean-freebsd11-x64-1

    not ok 695 parallel/test-gc-http-client
  ---
  duration_ms: 0.559
  severity: fail
  exitcode: 1
  stack: |-
    We should do 300 requests
    Done: 0/300
    Collected: 0/120
    events.js:167
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect ECONNRESET 127.0.0.1:51874 - Local (127.0.0.1:40194)
        at internalConnect (net.js:933:16)
        at defaultTriggerAsyncIdScope (internal/async_hooks.js:295:19)
        at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
        at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:63:10)
    Emitted 'error' event at:
        at Socket.socketErrorListener (_http_client.js:400:9)
        at Socket.emit (events.js:182:13)
        at emitErrorNT (internal/streams/destroy.js:82:8)
        at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
        at process._tickCallback (internal/process/next_tick.js:63:19)
  ...
  10. refack
    reopened this on Aug 30, 2018

  11. Trott commented on Sep 1, 2018

    @Trott
    Trott
    on Sep 1, 2018
    MemberAuthor

    This test seems to require more resources than other tests. I start getting timeouts with tools/test.py test/parallel/test-gc-http-client.js -j 32 --repeat 64 on my computer. I wonder if it can be refactored a bit or if it should be moved to sequential.

  12. 7 remaining items

  13. Trott commented on Sep 24, 2018

    @Trott
    Trott
    on Sep 24, 2018
    MemberAuthor

    Looks like test-gc-net-timeout is flaky enough to warrant it's on issue. Opening one...

  14. Trott
    added a commit that references this issue on Sep 25, 2018

    test: improve reliability of test-gc-http-client

    ae20e66

  15. Trott commented on Sep 25, 2018

    @Trott
    Trott
    on Sep 25, 2018
    MemberAuthor

    PR: #23087

  16. Trott commented on Sep 28, 2018

    @Trott
    Trott
    on Sep 28, 2018
    MemberAuthor

    I believe this is fixed by #23145

  17. Trott
    closed this as completedon Oct 26, 2018
  18. sam-github
    reopened this on Jun 7, 2019

  19. sam-github commented on Jun 7, 2019

    @sam-github
    sam-github
    on Jun 7, 2019
    Contributor

    This is still marked flaky in test/sequential/sequential.status. Is that not accurate? If it isn't, we should close this issue by PRing removal of the flaky status.

    If it is accurate the issue should still be open.

    Or perhaps the .status file points to the wrong issue, or something else should be done to reconcile this? @Trott

  20. Trott commented on Jun 8, 2019

    @Trott
    Trott
    on Jun 8, 2019
    MemberAuthor

    This is still marked flaky in test/sequential/sequential.status. Is that not accurate? If it isn't, we should close this issue by PRing removal of the flaky status.

    If it is accurate the issue should still be open.

    Or perhaps the .status file points to the wrong issue, or something else should be done to reconcile this? @Trott

    Yup. #28130

  21. Trott
    added a commit that references this issue on Jun 10, 2019

    test: remove test-gc-http-client from status file

    64d7056
  22. Trott
    closed this as completedin 64d7056on Jun 10, 2019
  23. BridgeAR
    added a commit that references this issue on Jun 17, 2019

    test: remove test-gc-http-client from status file

    d8061dc
  24. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: harden test-gc-http-client

    79642ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions