Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add no-misleading-character-class ESLint rule #22278

Closed
wants to merge 1 commit into from
Closed

tools: add no-misleading-character-class ESLint rule #22278

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

ESLint 5.3.0 adds a simple new rule that seems helpful for increasing Unicode support in JavaScript and Node.js: no-misleading-character-class.

Since we have already updated to the last version, we can toggle this rule on.

No relevant issues detected in our code or docs.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 12, 2018
@vsemozhetbyt
Copy link
Contributor Author

cc @nodejs/linting

@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 12, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 801c490
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the eslint-no-misleading-character-class branch August 12, 2018 16:47
vsemozhetbyt added a commit that referenced this pull request Aug 12, 2018
Refs: https://eslint.org/docs/rules/no-misleading-character-class

PR-URL: #22278
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 13, 2018
Refs: https://eslint.org/docs/rules/no-misleading-character-class

PR-URL: #22278
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants