tools: update ESLint to 5.3.0 #22134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the lite CI runs the linter and none of the other jobs in node-test-pull-request touch this code, the lite CI is probably sufficient here. |
|
Test failure is a known flaky (#21038). |
bengl
approved these changes
Aug 5, 2018
|
@nodejs/linting |
silverwind
approved these changes
Aug 5, 2018
|
Landed in 6ad12d4 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 8, 2018
PR-URL: nodejs#22134 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
PR-URL: #22134 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2 tasks
This was referenced Aug 16, 2018
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we made some efforts to make the ESLint updates in Node.js core a little bit less churn-y, maybe we can do more frequent smaller updates like this? (Or maybe it's still too churn-y?)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes