-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typos on e.g.
abbreviations
#21045
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eg.` was used in two places where `e.g.` was intended. Replace one instance with `e.g.` and rewrite the other instance to not require the abbreviation at all.
addaleax
approved these changes
May 30, 2018
vsemozhetbyt
approved these changes
May 30, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 30, 2018
trivikr
approved these changes
May 31, 2018
starkwang
approved these changes
May 31, 2018
tniessen
approved these changes
May 31, 2018
jasnell
approved these changes
May 31, 2018
lpinca
approved these changes
May 31, 2018
targos
approved these changes
May 31, 2018
@Trott build started: https://ci.nodejs.org/job/node-test-pull-request-lite/ |
benjamingr
approved these changes
Jun 1, 2018
hiroppy
approved these changes
Jun 1, 2018
Just in case anyone is puzzled by that comment, it was a github-bot test from @maclover7. It can be ignored. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 1, 2018
`eg.` was used in two places where `e.g.` was intended. Replace one instance with `e.g.` and rewrite the other instance to not require the abbreviation at all. PR-URL: nodejs#21045 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Landed in 7afe6c7 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
`eg.` was used in two places where `e.g.` was intended. Replace one instance with `e.g.` and rewrite the other instance to not require the abbreviation at all. PR-URL: #21045 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg.
was used in two places wheree.g.
was intended. Replace oneinstance with
e.g.
and rewrite the other instance to not require theabbreviation at all.
Checklist