-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins: start CI run on new pull requests #173
Conversation
This will start a CI build on all new pull requests in nodejs/node, that are opened by project collaborators
Behavior does not work due to how Jenkins handles redirects. URL will be available via GitHub statuses, so shouldn't be a big deal.
FYI I just installed a plugin that can do the triggering (and also parse comments). Still need the bot to communicate back. P.S. Adding notification hook, or polling the repo does not require elevated authorization. |
I got our Jankins to do similar stuff |
is there a way we can disable this? sometimes people open WIP prs where running a ci would just be a waste |
@refack Interesting! Personally, I prefer having the code live inside of a repo somewhere, so we avoid the black box of Jenkins plugins |
@devsnek I don't believe so -- this purposely only runs |
The Jenkins plugin has a label "blacklist" so PR with the |
PR-URL: #1307 Reviewed-By: Phillip Johnsen <johphi@gmail.com> Refs: nodejs/github-bot#173 Refs: https://github.com/nodejs-private/secrets/pull/19
If we could get this to post a |
Oh, I see that was attempted but ran into tech diff... |
This will start a CI build on all new pull requests in nodejs/node, that
are opened by project collaborators
cc @joyeecheung