Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: start CI run on new pull requests #173

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

maclover7
Copy link
Contributor

This will start a CI build on all new pull requests in nodejs/node, that
are opened by project collaborators

cc @joyeecheung

This will start a CI build on all new pull requests in nodejs/node, that
are opened by project collaborators
Behavior does not work due to how Jenkins handles redirects. URL will be
available via GitHub statuses, so shouldn't be a big deal.
@refack
Copy link
Contributor

refack commented May 31, 2018

FYI I just installed a plugin that can do the triggering (and also parse comments).
https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin

Still need the bot to communicate back.

P.S. Adding notification hook, or polling the repo does not require elevated authorization.

joyeecheung

This comment was marked as off-topic.

joyeecheung

This comment was marked as off-topic.

@refack
Copy link
Contributor

refack commented Jun 1, 2018

I got our Jankins to do similar stuff
nodejs/node#17330
I just need a token (or proxy it through the bot)

@devsnek
Copy link
Member

devsnek commented Jun 1, 2018

is there a way we can disable this? sometimes people open WIP prs where running a ci would just be a waste

@maclover7
Copy link
Contributor Author

@refack Interesting! Personally, I prefer having the code live inside of a repo somewhere, so we avoid the black box of Jenkins plugins

@maclover7
Copy link
Contributor Author

@devsnek I don't believe so -- this purposely only runs node-test-pull-request-lite so it shouldn't take up many resources. Also, it only runs when PRs are first opened, so at worst it would only be one build that is automatically triggered

@refack
Copy link
Contributor

refack commented Jun 1, 2018

The Jenkins plugin has a label "blacklist" so PR with the WIP label should be skipped

@maclover7 maclover7 merged commit 64c2b20 into nodejs:master Jun 1, 2018
@maclover7 maclover7 deleted the jm-ci-on-new-pr branch June 1, 2018 21:43
maclover7 added a commit to nodejs/build that referenced this pull request Jun 2, 2018
@Trott
Copy link
Member

Trott commented Jun 6, 2018

If we could get this to post a CI: <URL here> comment, that would rule.

@Trott
Copy link
Member

Trott commented Jun 6, 2018

Oh, I see that was attempted but ran into tech diff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants