[v8.x] module: add builtinModules#18220
[v8.x] module: add builtinModules#18220maclover7 wants to merge 1 commit intonodejs:v8.x-stagingfrom maclover7:backport-16386-to-v8.x
Conversation
Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) PR-URL: #16386 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
added
module
|
|
||
| * {string[]} | ||
|
|
||
| A list of the names of all modules provided by Node.js. Can be used to verify |
| * {string[]} | ||
|
|
||
| A list of the names of all modules provided by Node.js. Can be used to verify | ||
| if a module is maintained by a third-party module or not. |
There was a problem hiding this comment.
Just third party; modules don’t maintain, people do.
|
@ljharb those issues exist on master too, so they would need to be fixed first and then backported. If you would like to raise a PR against master that would be great. CI: |
|
Sure, but I’m not sure why they couldn’t also be fixed as part of the backport. |
General process is not to change things as part of backports because they don't get the same level of scrutiny as PRs to master. Also it can make life more difficult going forward, for example if the PR that fixes this in master also fixes some other issues, then that will have to be manually backported to this release with the changes that have already landed removed. |
Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) PR-URL: #16386 Backport-PR-URL: #18220 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in c5093fc |
5 participants
Provides list of all builtin modules in Node.
Includes modules of all types:
PR-URL: #16386
Refs: #3307
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
module