module: add builtinModules by maclover7 · Pull Request #16386 · nodejs/node

maclover7 · 2017-10-22T16:53:29Z

Provides list of all builtin modules in Node.

Includes modules of all types:

prefixed (ex: _tls_common)
deprecated (ex: sys)
regular (ex: vm)

Refs: #3307

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added --> where should this be documented? The Modules API guide contains things about user modules, not about require('module')'s API
commit message follows commit guidelines

Affected core subsystem(s)

module

cc @Fishrock123 @Trott

jasnell · 2017-10-22T17:03:07Z

lib/module.js

bikeshed nit: s/builtinModules/builtin (feel free to ignore)

I think this should definitely be plural, with or without Modules

jasnell · 2017-10-22T17:03:52Z

lib/module.js

perhaps startsWith instead of includes?

+1 for strictness

mscdex · 2017-10-22T17:10:36Z

Why is this using a getter instead of just exporting a list that's computed once (lazily or otherwise)? Or perhaps there is some way we can generate the list at compile time, which might be even better?

maclover7 · 2017-10-22T19:26:46Z

@mscdex So process.binding('natives') is created at compile time, but the issue is that we have to remove some items from that object. In theory, we could create a separate list of just the files we need for this property, but I'd rather stick with the current list, so that way it's less to update whenever new module files are added/removed.

mscdex · 2017-10-23T00:48:42Z

lib/module.js

Using a plain for-loop will be faster and we generally avoid using the functional array methods in node core.

I think for code that’s run a single time, we can choose to prefer clarity over performance.

gireeshpunathil · 2017-10-23T07:24:39Z

lib/module.js

How about the underscore'd (such as _tls_legacy)modules? should we inhibit them from being exposed?
This is the output with the current code:

[ 'async_hooks', 'assert', 'buffer', 'child_process', 'console', 'constants', 'crypto', 'cluster', 'dgram', 'dns', 'domain', 'events', 'fs', 'http', '_http_agent', '_http_client', '_http_common', '_http_incoming', '_http_outgoing', '_http_server', 'https', 'inspector', 'module', 'net', 'os', 'path', 'process', 'punycode', 'querystring', 'readline', 'repl', 'stream', '_stream_readable', '_stream_writable', '_stream_duplex', '_stream_transform', '_stream_passthrough', '_stream_wrap', 'string_decoder', 'sys', 'timers', 'tls', '_tls_common', '_tls_legacy', '_tls_wrap', 'tty', 'url', 'util', 'v8', 'vm', 'zlib' ]

Personally, +1 for exposing them, since they are files that can be required, and we wouldn't want a module name to conflict.

By the way, there is also repl._builtinLibs which I guess lives in the somewhat-documented-but-not-really-officially-supported zone, which only has the modules defined in the REPL/for --eval … I think that could cover the use case of “these are the libraries you actually want to use”?

i feel like it would make more sense to expose internal module's builtin lib array

bmeck · 2017-10-27T16:36:45Z

Should this be on module if there also exists a need for this in ESM? I am in particular wondering if we could have a resolve function that clearly handles this without exposing it as a boolean.

This might tie in with nodejs/TSC#389 if using a protocol or scope for builtin modules.

await import.meta.resolve('fs'); // node:fs

maclover7 · 2017-11-22T01:29:39Z

ping @addaleax @jasnell

bnoordhuis

I'm -.1 on adding this, there doesn't seem to be a pressing need.

My impression from #3307 is that it would be nice to have but that npm already has a working solution, and one they'll keep around for a long time too due to the need to support older node.js versions.

bnoordhuis · 2017-11-22T10:44:18Z

lib/module.js

Can be simplified to:

const builtinModules = Object.keys(process.binding('natives')).filter(s => !s.includes('/'));

And maybe .sort() it.

jdalton · 2017-11-22T14:54:55Z

lib/module.js

Is all the extra filtering beyond startsWith("internal/") needed? I think other places in Node just check for "internal/", so while module that start with v8/ and node-inspect/ aren't super great they're built-in and accessible via require() which is what really matters.

Not anymore: 0e10717

So it will now log a deprecation warning, but they're still accessible?
I think the bar should be:

Can the built-in module be required?

Yes - then it's in the list

No - then it's not

A deprecation warning, but still being able to be required, means it would be on the list, because folks can turn off deprecation warnings with --no-deprecation or --no-warnings.

maclover7 · 2017-11-22T19:58:33Z

@bnoordhuis Updated per comment. My thought was that since npm/the is-builtin-module npm package/jest/etc all depend on process.binding('natives'), it would be best to introduce an official API for this behavior, since it seems (obviously a little subjective) to be a common enough need.

jdalton · 2017-11-22T20:06:43Z

lib/module.js

The reason I'm interested in this is because I have a need for it in user-land as well, but providing incorrect info means it'll be ignored as bogus. Exposing something that's not accurate, via the !s.includes('/') filtered results, is not a good thing.

See my previous comment:

So it will now log a deprecation warning, but they're still accessible?
I think the bar should be:

Can the built-in module be required?

Yes - then it's in the list

No - then it's not

A deprecation warning, but still being able to be required, means it would be on the list, because folks can turn off deprecation warnings with --no-deprecation or --no-warnings.

I believe for an accurate list of requirable built-ins the filter should be just !s.startsWith("internal/")

Which aligns with

node/lib/internal/bootstrap_node.js

Line 517 in 07a4fa3

NativeModule._source = process.binding('natives');

node/lib/internal/bootstrap_node.js

Lines 566 to 568 in 07a4fa3

NativeModule.exists = function(id) {

return NativeModule._source.hasOwnProperty(id);

};

node/lib/internal/bootstrap_node.js

Lines 577 to 583 in 07a4fa3

NativeModule.nonInternalExists = function(id) {

return NativeModule.exists(id) && !NativeModule.isInternal(id);

};

NativeModule.isInternal = function(id) {

return id.startsWith('internal/');

};

You could even use NativeModule.nonInternalExists as the filter:

const builtinModules = Object.keys(NativeModule._source) .filter(NativeModule.nonInternalExists)

BridgeAR

I do not have a strong opinion but the code is LGTM

BridgeAR · 2017-11-23T11:24:35Z

lib/module.js

We might want to prevent tampering with this and use Object.freeze here.

maclover7 · 2017-11-24T21:30:30Z

updated @jdalton @BridgeAR

jdalton · 2017-11-25T04:26:45Z

lib/module.js

Since Module is exported as module.exports you can just bolt on builtinModules to

Module.builtinModules = builtinModules

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm)

maclover7 · 2017-11-26T00:30:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11710/

addaleax

LGTM with tests & docs

maclover7 · 2017-11-28T00:03:51Z

updated @addaleax -- if looks good to you, can you run CI

addaleax

LGTM, but no, CI is rebooting right now, so nobody can start that 😄

addaleax · 2017-11-28T00:13:03Z

test/parallel/test-module-builtin.js

+
+// Does not include internal modules
+assert.deepStrictEqual(
+  builtinModules.filter((mod) => { return mod.startsWith('internal/'); }),


tiny nit: I’d just write (mod) => mod.startsWith('internal/')

maclover7 · 2017-11-28T00:27:51Z

hehe was restarting while I was trying to land 17317, so that was fun :)

CI: https://ci.nodejs.org/job/node-test-pull-request/11764/

cjihrig · 2017-11-28T00:55:06Z

@bnoordhuis did you mean to write -.1, or did you mean -1? If it's -0.1, I assume that's not a blocking review.

addaleax · 2017-11-28T01:37:09Z

Landed in 1c1ef3c

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) Backport-PR-URL: #18221 PR-URL: #16386 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) Backport-PR-URL: #18221 PR-URL: #16386 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) Backport-PR-URL: #18221 PR-URL: #16386 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 30 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm) PR-URL: #16386 Backport-PR-URL: #18220 Refs: #3307 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * deps: * update V8 to 6.2.414.46 (Michaël Zasso) [#16413](#16413) * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [#16413](#16413) * upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * re land npm 5.6.0 (Myles Borins) [#18625](#18625) * ICU 60 bump (Steven R. Loomis) [#16876](#16876) * crypto: * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [#16130](#16130) * warn on invalid authentication tag length (Tobias Nießen) [#17566](#17566) * async_hooks: * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [#18004](#18004) * use typed array stack as fast path (Anna Henningsen) [#17780](#17780) * use scope for defaultTriggerAsyncId (Andreas Madsen) [#17273](#17273) * separate missing from default context (Andreas Madsen) [#17273](#17273) * rename initTriggerId (Andreas Madsen) [#17273](#17273) * deprecate undocumented API (Andreas Madsen) [#16972](#16972) * add destroy event for gced AsyncResources (Sebastian Mayr) [#16998](#16998) * add trace events to async_hooks (Andreas Madsen) [#15538](#15538) * set HTTPParser trigger to socket (Andreas Madsen) [#18003](#18003) * add provider types for net server (Andreas Madsen) [#17157](#17157) * n-api: * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109) * cli: * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [#16495](#16495) * console: * add support for console.debug (Benjamin Zaslavsky) [#17033](#17033) * module: * add builtinModules (Jon Moss) [#16386](#16386) * replace default paths in require.resolve() (cjihrig) [#17113](#17113) * src: * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109) * add process.ppid (cjihrig) [#16839](#16839) * http: * support generic `Duplex` streams (Anna Henningsen) [#16267](#16267) * add rawPacket in err of `clientError` event (XadillaX) [#17672](#17672) * better support for IPv6 addresses (Mattias Holmlund) [#14772](#14772) * net: * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [#17662](#17662) * process: * fix reading zero-length env vars on win32 (Anna Henningsen) [#18463](#18463) * tls: * unconsume stream on destroy (Anna Henningsen) [#17478](#17478) * process: * improve unhandled rejection message (Madara Uchiha) [#17158](#17158) * stream: * remove usage of *State.highWaterMark (Calvin Metcalf) [#12860](#12860) * trace_events: * add executionAsyncId to init events (Andreas Madsen) [#17196](#17196) PR-URL: #18336

ljharb · 2018-03-15T05:58:19Z

Shouldn't anything in this list be requireable without an error?

For example, require('v8/tools/profile') throws ReferenceError: CodeMap is not defined.

If a flag is required to make that module requireable, I'd expect the flag to be required for the module to show up in the list.

jdalton · 2018-03-15T06:05:14Z

require('v8/tools/profile') is still requirable and folks can still use it to detect if a feature is enabled by wrapping it in a try catch.

ljharb · 2018-03-15T06:06:11Z

I guess that's a fair point; it just seems unfortunate that the builtinModules list can't also be used as a way to filter out features that aren't enabled - since requiring non-requireable things throws too.

jdalton · 2018-03-15T06:07:19Z

It's a low level bit, folks can add filtering on top of it to taste.
There's a PR to expose process.envFlags which might be something you'll dig.

This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 30 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) nodejs#12678 * crypto: - expose ECDH class (Bryan English) nodejs#8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) nodejs#10209 - warn on invalid authentication tag length (Tobias Nießen) nodejs#17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) nodejs#16835 * dgram: - added socket.setMulticastInterface() (Will Young) nodejs#7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) nodejs#13005 * lib: - return this from net.Socket.end() (Sam Roberts) nodejs#13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) nodejs#16386 * net: - return this from getConnections() (Sam Roberts) nodejs#13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) nodejs#13784 * repl: - improve require() autocompletion (Alexey Orlenko) nodejs#14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) nodejs#16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) nodejs#12087 - add process.ppid (cjihrig) nodejs#16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) nodejs#12839 * tools, build: - a new macOS installer! (JP Wesselink) nodejs#15179 * url: - WHATWG URL api support (James M Snell) nodejs#7448 * util: - add %i and %f formatting specifiers (Roman Reiss) nodejs#10308 PR-URL: nodejs#18342

Notable changes: * deps: * update V8 to 6.2.414.46 (Michaël Zasso) [nodejs#16413](nodejs#16413) * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [nodejs#16413](nodejs#16413) * upgrade libuv to 1.19.1 (cjihrig) [nodejs#18260](nodejs#18260) * re land npm 5.6.0 (Myles Borins) [nodejs#18625](nodejs#18625) * ICU 60 bump (Steven R. Loomis) [nodejs#16876](nodejs#16876) * crypto: * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [nodejs#16130](nodejs#16130) * warn on invalid authentication tag length (Tobias Nießen) [nodejs#17566](nodejs#17566) * async_hooks: * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [nodejs#18004](nodejs#18004) * use typed array stack as fast path (Anna Henningsen) [nodejs#17780](nodejs#17780) * use scope for defaultTriggerAsyncId (Andreas Madsen) [nodejs#17273](nodejs#17273) * separate missing from default context (Andreas Madsen) [nodejs#17273](nodejs#17273) * rename initTriggerId (Andreas Madsen) [nodejs#17273](nodejs#17273) * deprecate undocumented API (Andreas Madsen) [nodejs#16972](nodejs#16972) * add destroy event for gced AsyncResources (Sebastian Mayr) [nodejs#16998](nodejs#16998) * add trace events to async_hooks (Andreas Madsen) [nodejs#15538](nodejs#15538) * set HTTPParser trigger to socket (Andreas Madsen) [nodejs#18003](nodejs#18003) * add provider types for net server (Andreas Madsen) [nodejs#17157](nodejs#17157) * n-api: * add helper for addons to get the event loop (Anna Henningsen) [nodejs#17109](nodejs#17109) * cli: * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [nodejs#16495](nodejs#16495) * console: * add support for console.debug (Benjamin Zaslavsky) [nodejs#17033](nodejs#17033) * module: * add builtinModules (Jon Moss) [nodejs#16386](nodejs#16386) * replace default paths in require.resolve() (cjihrig) [nodejs#17113](nodejs#17113) * src: * add helper for addons to get the event loop (Anna Henningsen) [nodejs#17109](nodejs#17109) * add process.ppid (cjihrig) [nodejs#16839](nodejs#16839) * http: * support generic `Duplex` streams (Anna Henningsen) [nodejs#16267](nodejs#16267) * add rawPacket in err of `clientError` event (XadillaX) [nodejs#17672](nodejs#17672) * better support for IPv6 addresses (Mattias Holmlund) [nodejs#14772](nodejs#14772) * net: * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [nodejs#17662](nodejs#17662) * process: * fix reading zero-length env vars on win32 (Anna Henningsen) [nodejs#18463](nodejs#18463) * tls: * unconsume stream on destroy (Anna Henningsen) [nodejs#17478](nodejs#17478) * process: * improve unhandled rejection message (Madara Uchiha) [nodejs#17158](nodejs#17158) * stream: * remove usage of *State.highWaterMark (Calvin Metcalf) [nodejs#12860](nodejs#12860) * trace_events: * add executionAsyncId to init events (Andreas Madsen) [nodejs#17196](nodejs#17196) PR-URL: nodejs#18336

Summary: Added in node 9.3. nodejs/node#16386 I'm unable to compile (`make: *** [_build/src/common/xx/xx_stubs.o] Error 2`), thus enable to run the tests and fix the assertion Pull Request resolved: #5529 Reviewed By: dsainati1 Differential Revision: D13829969 Pulled By: nmote fbshipit-source-id: 2e265d9f747737d9f0ccda16f7300f9c5bee469f

nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Oct 22, 2017

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 22, 2017

jasnell reviewed Oct 22, 2017

View reviewed changes

mscdex reviewed Oct 23, 2017

View reviewed changes

gireeshpunathil reviewed Oct 23, 2017

View reviewed changes

cjihrig mentioned this pull request Oct 27, 2017

module: add API for identifying core modules #16555

Closed

4 tasks

bnoordhuis reviewed Nov 22, 2017

View reviewed changes

jdalton reviewed Nov 22, 2017

View reviewed changes

BridgeAR approved these changes Nov 23, 2017

View reviewed changes

jdalton reviewed Nov 25, 2017

View reviewed changes

module: add builtinModules

46f19ef

Provides list of all builtin modules in Node. Includes modules of all types: - prefixed (ex: _tls_common) - deprecated (ex: sys) - regular (ex: vm)

jasnell approved these changes Nov 26, 2017

View reviewed changes

addaleax approved these changes Nov 27, 2017

View reviewed changes

[squash] add tests and docs

846dea6

addaleax approved these changes Nov 28, 2017

View reviewed changes

nit: addaleax comment

1446041

cjihrig approved these changes Nov 28, 2017

View reviewed changes

gibfahn added backported-to-v8.x and removed backport-requested-v8.x labels Feb 19, 2018

sverweij mentioned this pull request Jul 16, 2019

build(npm): only support node versions supported by Node.js sverweij/dependency-cruiser#175

Merged

8 tasks

watson mentioned this pull request Nov 20, 2019

doc: add missing 'added' versions to module.builtinModules #30562

Closed

2 tasks

	NativeModule.exists = function(id) {
	return NativeModule._source.hasOwnProperty(id);
	};

	NativeModule.nonInternalExists = function(id) {
	return NativeModule.exists(id) && !NativeModule.isInternal(id);
	};

	NativeModule.isInternal = function(id) {
	return id.startsWith('internal/');
	};

Uh oh!

Conversation

maclover7 commented Oct 22, 2017

Checklist

Affected core subsystem(s)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mscdex commented Oct 22, 2017

Uh oh!

maclover7 commented Oct 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maclover7 Oct 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devsnek Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmeck commented Oct 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maclover7 commented Nov 22, 2017

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdalton Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdalton Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Nov 22, 2017

Uh oh!

jdalton Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Nov 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Nov 26, 2017

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Nov 28, 2017

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

maclover7 Oct 23, 2017 •

edited

Loading

devsnek Nov 22, 2017 •

edited

Loading

bmeck commented Oct 27, 2017 •

edited

Loading

jdalton Nov 22, 2017 •

edited

Loading

jdalton Nov 22, 2017 •

edited

Loading

jdalton Nov 22, 2017 •

edited

Loading

jdalton commented Mar 15, 2018 •

edited

Loading

jdalton commented Mar 15, 2018 •

edited

Loading