Skip to content

deps: upgrade libuv to 1.15.0 #15745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2017
Merged

deps: upgrade libuv to 1.15.0 #15745

merged 1 commit into from
Oct 5, 2017

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 3, 2017 •
edited
Loading

Notable Changes

  • A lot of work toward NetBSD support.
  • Several bug fixes for uv_fs_copyfile(), which is used by fs.copyFile().
  • Updated UV_PROCESS_WINDOWS_HIDE to hide console windows.

Refs: #15380
Refs: #15683
Fixes: #15394

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels Oct 3, 2017
@mscdex
Copy link
Contributor

mscdex commented Oct 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10389/

@jasnell
Copy link
Member

jasnell commented Oct 3, 2017

Can you provide a summary of the key changes in the PR text above?

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 3, 2017

CI looks good. Only failures appear to be related to #14404 and #15558.

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 3, 2017

I've added some notable changes and linked to some issues for the PR metadata. To be honest, there isn't a ton that Node should care too much about, although @evanlucas might be interested to see that @bnoordhuis picked up libuv/libuv#641.

@evanlucas
Copy link
Contributor

Thanks @bnoordhuis! I couldn't quite get it right :].

@bricss bricss mentioned this pull request Oct 4, 2017
Merged
@santigimeno santigimeno mentioned this pull request Oct 4, 2017
Closed
@santigimeno
Copy link
Member

It fixes: #15770 too

@cjihrig
deps: upgrade libuv to 1.15.0
75318e4 
Refs: nodejs#15380
Refs: nodejs#15683
Fixes: nodejs#15394
Fixes: nodejs#15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 75318e4 into nodejs:master Oct 5, 2017
@cjihrig cjihrig deleted the libuv branch October 5, 2017 17:45
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 5, 2017
@cjihrig @Trott
deps: upgrade libuv to 1.15.0
fca6c58 
PR-URL: nodejs#15745
Refs: nodejs#15380
Refs: nodejs#15683
Fixes: nodejs#15394
Fixes: nodejs#15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 5, 2017

Force pushed fca6c58 to add the missing metadata.

MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.15.0
14f38fe 
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mattiash mattiash mentioned this pull request Oct 10, 2017
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.15.0
77bdfc9 
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
@MylesBorins
2017-10-11, Node.js Version 8.7.0 (Current)
dc4f1b9 
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
MylesBorins added a commit that referenced this pull request Oct 11, 2017
@MylesBorins
2017-10-11, Node.js Version 8.7.0 (Current)
b7fec86 
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@cjihrig @addaleax
deps: upgrade libuv to 1.15.0
bd355f2 
PR-URL: nodejs/node#15745
Refs: nodejs/node#15380
Refs: nodejs/node#15683
Fixes: nodejs/node#15394
Fixes: nodejs/node#15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@MylesBorins @addaleax
2017-10-11, Node.js Version 8.7.0 (Current)
4b1e46b 
Notable Changes:

* deps:
  * update npm to 5.4.2
    nodejs/node#15600
  * upgrade libuv to 1.15.0
    nodejs/node#15745
  * update V8 to 6.1.534.42
    nodejs/node#15393
* dgram:
  * support for setting dgram socket buffer size
    nodejs/node#13623
* fs:
  * add support O_DSYNC file open constant
    nodejs/node#15451
* util:
  * deprecate obj.inspect for custom inspection
    nodejs/node#15631
* tools, build:
  * there is a fancy new macOS installer
    nodejs/node#15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: nodejs/node#15762
@MylesBorins
Copy link
Contributor

Do we want to include this in the upcoming 6.x LTS minor? It may be the last minor for the 6.x release line. That being said I don't want to rush ti if this could potentially complicate things

/cc @nodejs/tsc @nodejs/lts

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 16, 2017

I think this would be good to get into Node 6 due to the mentioned notable changes. I understand if people don't want to rush it though.

@mscdex
Copy link
Contributor

mscdex commented Oct 16, 2017

Are we sure that recent versions of libuv still work on all of the platforms supported by node v6.x?

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 16, 2017

As of 1.12.0, it was safe to backport. I just looked through the Changelog since then, and it still appears to be the case. Perhaps @bnoordhuis can confirm though.

@bnoordhuis
Copy link
Member

Yes, no legacy code has been removed so far.

@MylesBorins MylesBorins added land-on-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Oct 17, 2017
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.15.0
4a95650 
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.15.0
02e4303 
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Nov 6, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
c6a2ec5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
70dc6d5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-fs-copyfile

10 participants

@cjihrig @mscdex @jasnell @evanlucas @santigimeno @Trott @MylesBorins @bnoordhuis @refack @nodejs-github-bot