deps: upgrade libuv to 1.15.0 by cjihrig · Pull Request #15745 · nodejs/node

cjihrig · 2017-10-03T00:15:14Z

Notable Changes

A lot of work toward NetBSD support.
Several bug fixes for uv_fs_copyfile(), which is used by fs.copyFile().
Updated UV_PROCESS_WINDOWS_HIDE to hide console windows.

Refs: #15380
Refs: #15683
Fixes: #15394

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

mscdex · 2017-10-03T00:40:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10389/

jasnell · 2017-10-03T00:43:46Z

Can you provide a summary of the key changes in the PR text above?

cjihrig · 2017-10-03T01:36:15Z

CI looks good. Only failures appear to be related to #14404 and #15558.

cjihrig · 2017-10-03T01:57:08Z

I've added some notable changes and linked to some issues for the PR metadata. To be honest, there isn't a ton that Node should care too much about, although @evanlucas might be interested to see that @bnoordhuis picked up libuv/libuv#641.

evanlucas · 2017-10-03T14:39:36Z

Thanks @bnoordhuis! I couldn't quite get it right :].

santigimeno · 2017-10-05T12:44:15Z

It fixes: #15770 too

Refs: nodejs#15380 Refs: nodejs#15683 Fixes: nodejs#15394 Fixes: nodejs#15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#15745 Refs: nodejs#15380 Refs: nodejs#15683 Fixes: nodejs#15394 Fixes: nodejs#15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2017-10-05T19:10:27Z

Force pushed fca6c58 to add the missing metadata.

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes: * deps: * update npm to 5.4.2 #15600 * upgrade libuv to 1.15.0 #15745 * update V8 to 6.1.534.42 #15393 * dgram: * support for setting dgram socket buffer size #13623 * fs: * add support O_DSYNC file open constant #15451 * util: * deprecate obj.inspect for custom inspection #15631 * tools, build: * there is a fancy new macOS installer #15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: #15762

PR-URL: nodejs/node#15745 Refs: nodejs/node#15380 Refs: nodejs/node#15683 Fixes: nodejs/node#15394 Fixes: nodejs/node#15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes: * deps: * update npm to 5.4.2 nodejs/node#15600 * upgrade libuv to 1.15.0 nodejs/node#15745 * update V8 to 6.1.534.42 nodejs/node#15393 * dgram: * support for setting dgram socket buffer size nodejs/node#13623 * fs: * add support O_DSYNC file open constant nodejs/node#15451 * util: * deprecate obj.inspect for custom inspection nodejs/node#15631 * tools, build: * there is a fancy new macOS installer nodejs/node#15179 * Added new collaborator * bmeurer - Benedikt Meurer - https://github.com/bmeurer * kfarnung - Kyle Farnung - https://github.com/kfarnung PR-URL: nodejs/node#15762

MylesBorins · 2017-10-16T21:47:21Z

Do we want to include this in the upcoming 6.x LTS minor? It may be the last minor for the 6.x release line. That being said I don't want to rush ti if this could potentially complicate things

/cc @nodejs/tsc @nodejs/lts

cjihrig · 2017-10-16T21:50:48Z

I think this would be good to get into Node 6 due to the mentioned notable changes. I understand if people don't want to rush it though.

mscdex · 2017-10-16T21:57:20Z

Are we sure that recent versions of libuv still work on all of the platforms supported by node v6.x?

cjihrig · 2017-10-16T22:15:24Z

As of 1.12.0, it was safe to backport. I just looked through the Changelog since then, and it still appears to be the case. Perhaps @bnoordhuis can confirm though.

bnoordhuis · 2017-10-17T17:52:33Z

Yes, no legacy code has been removed so far.

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263

nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels Oct 3, 2017

jasnell approved these changes Oct 3, 2017

View reviewed changes

refack approved these changes Oct 3, 2017

View reviewed changes

bricss mentioned this pull request Oct 4, 2017

v8.7.0 proposal #15762

Merged

santigimeno mentioned this pull request Oct 4, 2017

copyFileSync expected behavior? #15770

Closed

deps: upgrade libuv to 1.15.0

75318e4

Refs: nodejs#15380 Refs: nodejs#15683 Fixes: nodejs#15394 Fixes: nodejs#15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig force-pushed the libuv branch from 108856b to 75318e4 Compare October 5, 2017 17:44

cjihrig merged commit 75318e4 into nodejs:master Oct 5, 2017

cjihrig deleted the libuv branch October 5, 2017 17:45

MylesBorins pushed a commit that referenced this pull request Oct 7, 2017

deps: upgrade libuv to 1.15.0

14f38fe

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

mattiash mentioned this pull request Oct 10, 2017

Issue 14736 tls ipv6 address #14772

Closed

4 tasks

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017

deps: upgrade libuv to 1.15.0

77bdfc9

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added land-on-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Oct 17, 2017

MylesBorins pushed a commit that referenced this pull request Oct 17, 2017

deps: upgrade libuv to 1.15.0

4a95650

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins pushed a commit that referenced this pull request Oct 25, 2017

deps: upgrade libuv to 1.15.0

02e4303

PR-URL: #15745 Refs: #15380 Refs: #15683 Fixes: #15394 Fixes: #15770 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: upgrade libuv to 1.15.0#15745

deps: upgrade libuv to 1.15.0#15745
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:libuv

cjihrig commented Oct 3, 2017 •

edited

Loading

Uh oh!

mscdex commented Oct 3, 2017

Uh oh!

jasnell commented Oct 3, 2017

Uh oh!

cjihrig commented Oct 3, 2017

Uh oh!

cjihrig commented Oct 3, 2017

Uh oh!

evanlucas commented Oct 3, 2017

Uh oh!

santigimeno commented Oct 5, 2017

Uh oh!

Trott commented Oct 5, 2017

Uh oh!

MylesBorins commented Oct 16, 2017

Uh oh!

cjihrig commented Oct 16, 2017

Uh oh!

mscdex commented Oct 16, 2017

Uh oh!

cjihrig commented Oct 16, 2017

Uh oh!

bnoordhuis commented Oct 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

cjihrig commented Oct 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Changes

Checklist

Affected core subsystem(s)

Uh oh!

mscdex commented Oct 3, 2017

Uh oh!

jasnell commented Oct 3, 2017

Uh oh!

cjihrig commented Oct 3, 2017

Uh oh!

cjihrig commented Oct 3, 2017

Uh oh!

evanlucas commented Oct 3, 2017

Uh oh!

santigimeno commented Oct 5, 2017

Uh oh!

Trott commented Oct 5, 2017

Uh oh!

MylesBorins commented Oct 16, 2017

Uh oh!

cjihrig commented Oct 16, 2017

Uh oh!

mscdex commented Oct 16, 2017

Uh oh!

cjihrig commented Oct 16, 2017

Uh oh!

bnoordhuis commented Oct 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cjihrig commented Oct 3, 2017 •

edited

Loading