-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: improve contributors guide #15123
Closed
Closed
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f1ea863
meta: improve contributors guide
jasnell f3cfc25
[Squash] Add table of contents
jasnell b12145b
[Squash] Nits
jasnell ba61d4f
[Squash] Nits
jasnell 94adf37
[Squash] Nits
jasnell 89f13de
[Squash] Nit
jasnell ce08403
[Squash] Nit
jasnell daf0847
[Squash] Pull in specific details of review process, define bad actors
jasnell 7112e6a
[Squash] Further clarification
jasnell 37658eb
[Squash] update ToC
jasnell c30e05b
[Squash] typo
jasnell 4969cee
[Squash] nits
jasnell 384690e
[Squash] nits
jasnell 2fa8193
[Squash] nits
jasnell 122e36f
[Squash] Nits
jasnell 3a76fdf
[Squash] Nits
jasnell 880c2f3
[Squash] Nits
jasnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
[Squash] Nits
- Loading branch information
commit 880c2f31a84fe2ef26b45fb04bc47a0da3080d3d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't my local branch typically track
upstream/master
?