Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: improve contributors guide #15123

Closed
wants to merge 17 commits into from
Closed

meta: improve contributors guide #15123

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f1ea863
meta: improve contributors guide
jasnell Aug 31, 2017
f3cfc25
[Squash] Add table of contents
jasnell Aug 31, 2017
b12145b
[Squash] Nits
jasnell Aug 31, 2017
ba61d4f
[Squash] Nits
jasnell Aug 31, 2017
94adf37
[Squash] Nits
jasnell Aug 31, 2017
89f13de
[Squash] Nit
jasnell Aug 31, 2017
ce08403
[Squash] Nit
jasnell Aug 31, 2017
daf0847
[Squash] Pull in specific details of review process, define bad actors
jasnell Aug 31, 2017
7112e6a
[Squash] Further clarification
jasnell Aug 31, 2017
37658eb
[Squash] update ToC
jasnell Sep 1, 2017
c30e05b
[Squash] typo
jasnell Sep 1, 2017
4969cee
[Squash] nits
jasnell Sep 1, 2017
384690e
[Squash] nits
jasnell Sep 1, 2017
2fa8193
[Squash] nits
jasnell Sep 1, 2017
122e36f
[Squash] Nits
jasnell Sep 1, 2017
3a76fdf
[Squash] Nits
jasnell Sep 1, 2017
880c2f3
[Squash] Nits
jasnell Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] nits
  • Loading branch information
@jasnell
jasnell committed Sep 1, 2017
commit 2fa819333e6cd0228bb91e458ea36ed074c913cd
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
```

Please try to do your best at filling out the details but feel free to skip
Please try to do your best at filling out the details, but feel free to skip
parts if you're not sure what to put.

Once opened, Pull Requests are usually reviewed within a few days.
Expand Down