Repository navigation
deps: Intl: ICU 57 bump #6058
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.
Description
Activity
- addedbuildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.
on Apr 5, 2016 @srl295 cc me when you have a PR in and I'll test it out
@thealphanerd thx, let me verify windows first. Passes all tests except
test-tick-processorwhich I doubt I broke (famous last words?)Reacted by Myles Borins@srl295 no, you didn't 😺
See #5903 (comment)Looks like
cstr.cppbreaks under MSVC because of IcuBug:12451.The good part is, the fix would essentially
#ifdefout this file for node's use, so I can probably just add it to the exclusion list for essentially the same behavior.@jbergstroem not "required for" but "ideally lands before" to avoid having to bump #3476 itself also.
Re the known issues:- node/v8 does not use Transliteration, so is unaffected. The data and code is not included in node.
- the Visual Studio issues are for building ICU from ICU's project files, which node doesn't use (hi
gyp). I have updated the known issues to be more clear.
works on windows… PR incoming
- added 2 commits that reference this issue
on Apr 5, 2016 12 remaining items
- added a commit that references this issue
on Apr 25, 2016 - added a commit that references this issue
on Apr 26, 2016 - added a commit that references this issue
on May 3, 2016 - added a commit that references this issue
on Jun 1, 2016 fyi @jasnell
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.
Bump from 56 to 57, http://site.icu-project.org/download/57 released 2016-03-23
follow on to #2917