Skip to content

Intl: ICU 55 to 56 bump #2917

Description

@srl295

Activity

  1. added
    i18n-apiIssues and PRs related to Node.js internationalization support.
    on Sep 16, 2015
  2. self-assigned this
    on Sep 16, 2015
  3. srl295 commented on Sep 25, 2015

    @srl295
    MemberAuthor

    ICU 56r1 dropped today. Interested parties can test (noting #3065 which could bite you ) with:

     ./configure --with-icu-source=http://download.icu-project.org/files/icu4c/56rc/icu4c-56_rc-src.zip --with-intl=full-icu --download=all
    
  4. rvagg commented on Sep 29, 2015

    @rvagg
    Member

    @srl295 if/when you bump to 56 in the configure could you try and give us a quick summary of improvements that can go in the changelog? Is it simply just "perf"?

  5. srl295 commented on Sep 29, 2015

    @srl295
    MemberAuthor

    Yes definitely. I will expand on the changes.

    There's always fresh data, latest time zone changes and such. But there are
    other improvements I will note. No new features.

  6. srl295 commented on Oct 7, 2015

    @srl295
    MemberAuthor

    Heads up - ICU 56 planned GA today. I'll be submitting a PR soon

  7. srl295 commented on Oct 7, 2015

    @srl295
    MemberAuthor

    Summarizing from here

    • CLDR 28 5% new data, 8% corrections

    Which reminds me, I will need to review the icutrim behavior - some new data categories to trim out.

    This would affect string normalization, etc.

    • ICU data size reduced by about 7.2% (1.8MB) via sharing string values across resource bundles.
    • Support for locale key "cf" to specify currency format style, and interaction with NumberFormat values for UNumberFormatStyle: [doc: update to current V8 versions #11787]

    I assume this will pass through to Intl but need to test. example would be locale en-us-u-cf-account for negative numbers like (4.56) instead of -4.56

    • Larger UnicodeString object

    More on stack, less heap. Should reduce heap usage.

    14% to 72% improvements for some cases! Usual benchmark disclaimers apply!

    • Collator: first-time startup time improved 20% due to precalculated unsafe-backward table

    My personal contribution to this list.

    • A number of memory leaks and buffer overruns have been fixed based on static code analysis, mostly in data build tools.

    And of course,

    • latest time zone data
  8. added
    wipIssues and PRs that are still a work in progress.
    on Oct 7, 2015
  9. srl295 commented on Oct 7, 2015

    @srl295
    MemberAuthor

    Note that #3065 enables building full-icu, not the default small-icu. Given the timing, I'll fix the remaining 56 issues in this issue instead.

    Looks like a false alarm / unclean local build dir. Clean build worked fine.

  10. srl295 commented on Oct 8, 2015

    @srl295
    MemberAuthor

    Looks like so far, the delta for small-icu and full-icu from ICU 55 to 56 is about 700k on linux x64. May be possible to trim further but i'd probably not (at this point) unless there's a call to.

  11. srl295 commented on Oct 8, 2015

    @srl295
    MemberAuthor

    perf ICU 56 makes for(var k=0;k<10000;k++) { (123.45) .toLocaleString(); } run about twice as fast as ICU 55. ..

    edit and it gets better... var nf = new Intl.NumberFormat(); for (...) { nf.format(123.45); } is more like 3x faster

  12. srl295 commented on Oct 8, 2015

    @srl295
    MemberAuthor
  13. jasnell commented on Oct 8, 2015

    @jasnell
    Member

    @srl295 ... when you get that PR open, please tag it land-on-v4x and mention me in it so I can track it for the 4.2.0 release

  14. added a commit that references this issue on Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

i18n-apiIssues and PRs related to Node.js internationalization support.wipIssues and PRs that are still a work in progress.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions