Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in error code ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED #52448

Closed
mootari opened this issue Apr 10, 2024 · 2 comments · Fixed by #52627
Closed

Typo in error code ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED #52448

mootari opened this issue Apr 10, 2024 · 2 comments · Fixed by #52627
Labels
confirmed-bug Issues with confirmed bugs. errors Issues and PRs related to JavaScript errors originated in Node.js core. tls Issues and PRs related to the tls subsystem.

Comments

@mootari
Copy link
Contributor

mootari commented Apr 10, 2024 •
edited
Loading

Version

v21.7.2

Description

One of the error codes, ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED, misspells "identity". The code was introduced in 2019 when PSK support got added in #23188.

The issue is purely cosmetic since all other sources and documents reference the correct (i.e. misspelled) code.

Additional information

It's probably too late (or simply not worth it) to fix it now, so I'm filing this issue mostly for posterity.
@VoltrexKeyva VoltrexKeyva added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 10, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Apr 21, 2024 •
edited
Loading

Thanks for the issue! If you'd like to open a PR to fix it, the team would be happy to review! (Plus you'll get a shiny "contributor" badge if merged 😀 )

I think it is worth it to fix it, as even the little things can cause issues down the line

@RedYetiDev RedYetiDev added confirmed-bug Issues with confirmed bugs. tls Issues and PRs related to the tls subsystem. labels Apr 21, 2024
@RedYetiDev RedYetiDev mentioned this issue Apr 21, 2024
Merged
@RedYetiDev
Copy link
Member

I've opened a PR to resolve this issue. You have been marked as the Co-Author. If you'd prefer not be mentioned in the PR, please let me know.

nodejs-github-bot pushed a commit that referenced this issue Sep 20, 2024
@RedYetiDev @mootari
tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo
f666a1b 
Co-Authored-By: Fabian Iwand <mootari@users.noreply.github.com>
PR-URL: #52627
Fixes: #52448
Refs: #23188
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@RedYetiDev @mootari @louwers
tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo
921fb1f 
Co-Authored-By: Fabian Iwand <mootari@users.noreply.github.com>
PR-URL: nodejs#52627
Fixes: nodejs#52448
Refs: nodejs#23188
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. errors Issues and PRs related to JavaScript errors originated in Node.js core. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo RedYetiDev/node
3 participants
@mootari @RedYetiDev @VoltrexKeyva