fs: improve error performance of fchownSync
#40047
Annotations
3 errors
test-asan:
test/parallel/test-fs-error-messages.js#L772
--- stderr ---
node:assert:125
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'syncFs is not defined'
- 'EBADF: bad file descriptor, fchown'
at Object.validateError (/home/runner/work/node/node/test/parallel/test-fs-error-messages.js:772:12)
at expectedException (node:assert:724:17)
at expectsError (node:assert:847:3)
at Function.throws (node:assert:902:3)
at /home/runner/work/node/node/test/parallel/test-fs-error-messages.js:783:12
at Proxy.runWithInvalidFD (/home/runner/work/node/node/test/common/index.js:808:12)
at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-fs-error-messages.js:779:10)
at Module._compile (node:internal/modules/cjs/loader:1369:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
at Module.load (node:internal/modules/cjs/loader:1201:32) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: 'syncFs is not defined',
expected: 'EBADF: bad file descriptor, fchown',
operator: 'strictEqual'
}
Node.js v21.0.0-pre
Command: out/Release/node --expose-internals --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-fs-error-messages.js
|
test-asan:
test/parallel/test-trace-events-fs-sync.js#L132
--- stderr ---
/home/runner/work/node/node/test/parallel/test-trace-events-fs-sync.js:132
throw new Error(`${tr}:\n${util.inspect(proc)}`);
^
Error: fs.sync.fchown:
{
status: 1,
signal: null,
output: [
null,
'',
'node:fs:2062\n' +
' return syncFs.fchown(fd, uid, gid);\n' +
' ^\n' +
'\n' +
'ReferenceError: syncFs is not defined\n' +
' at Object.fchownSync (node:fs:2062:3)\n' +
' at [eval]:1:87\n' +
' at Script.runInThisContext (node:vm:122:12)\n' +
' at Object.runInThisContext (node:vm:296:38)\n' +
' at node:internal/process/execution:83:21\n' +
' at [eval]-wrapper:6:24\n' +
' at runScript (node:internal/process/execution:82:62)\n' +
' at evalScript (node:internal/process/execution:104:10)\n' +
' at node:internal/main/eval_string:51:3\n' +
'\n' +
'Node.js v21.0.0-pre\n'
],
pid: 147252,
stdout: '',
stderr: 'node:fs:2062\n' +
' return syncFs.fchown(fd, uid, gid);\n' +
' ^\n' +
'\n' +
'ReferenceError: syncFs is not defined\n' +
' at Object.fchownSync (node:fs:2062:3)\n' +
' at [eval]:1:87\n' +
' at Script.runInThisContext (node:vm:122:12)\n' +
' at Object.runInThisContext (node:vm:296:38)\n' +
' at node:internal/process/execution:83:21\n' +
' at [eval]-wrapper:6:24\n' +
' at runScript (node:internal/process/execution:82:62)\n' +
' at evalScript (node:internal/process/execution:104:10)\n' +
' at node:internal/main/eval_string:51:3\n' +
'\n' +
'Node.js v21.0.0-pre\n'
}
at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-trace-events-fs-sync.js:132:11)
at Module._compile (node:internal/modules/cjs/loader:1369:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
at Module.load (node:internal/modules/cjs/loader:1201:32)
at Module._load (node:internal/modules/cjs/loader:1017:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:103:12)
at node:internal/main/run_main_module:23:47
Node.js v21.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-trace-events-fs-sync.js
|
test-asan
Process completed with exit code 2.
|